Skip to content

change width="0" to width="" #2742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redallen merged 3 commits into from
Aug 21, 2019
Merged

change width="0" to width="" #2742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6da50c3
change width=0 to width=""
redallen Aug 20, 2019
cf86d71
fix snapshots
redallen Aug 20, 2019
e37f0b1
fix more snapshots
redallen Aug 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/patternfly-4/react-core/src/components/BackgroundImage/BackgroundImage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export const BackgroundImage: React.FunctionComponent<BackgroundImageProps> = ({
return (
<div className={css(styles.backgroundImage, bgStyles.bgOverrides, className)} {...props}>
<svg xmlns="http://www.w3.org/2000/svg" className="pf-c-background-image__filter" width="0" height="0">
<filter id="image_overlay" width="0">
<filter id="image_overlay" width="">
<feColorMatrix type="matrix"
values="1 0 0 0 0
1 0 0 0 0
Expand Down
6 changes: 3 additions & 3 deletions ...y-4/react-core/src/components/BackgroundImage/__snapshots__/BackgroundImage.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ exports[`BackgroundImage 1`] = `
>
<filter
id="image_overlay"
width="0"
width=""
>
<feColorMatrix
type="matrix"
Expand Down Expand Up @@ -67,7 +67,7 @@ exports[`BackgroundImage 2`] = `
>
<filter
id="image_overlay"
width="0"
width=""
>
<feColorMatrix
type="matrix"
Expand Down Expand Up @@ -118,7 +118,7 @@ exports[`allows passing in a single string as the image src 1`] = `
>
<filter
id="image_overlay"
width="0"
width=""
>
<feColorMatrix
type="matrix"
Expand Down