Skip to content

Conversation

@jessiehuff
Copy link
Contributor

This was noticed in the context of data list selectable rows and selectable cards. If the action/toggle was selected by keyboard, the entire parent (the row or card) would be selected.

What: Closes #3617

@patternfly-build
Copy link
Collaborator

patternfly-build commented Feb 21, 2020

@codecov-io
Copy link

codecov-io commented Feb 21, 2020

Codecov Report

Merging #3816 into master will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3816      +/-   ##
==========================================
- Coverage      71%   70.98%   -0.02%     
==========================================
  Files         785      785              
  Lines       10638    10641       +3     
  Branches     2314     2316       +2     
==========================================
+ Hits         7553     7554       +1     
- Misses       2655     2657       +2     
  Partials      430      430
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 85.89% <ø> (ø) ⬆️
#patternfly4 60% <33.33%> (-0.02%) ⬇️
Impacted Files Coverage Δ
...ly-4/react-core/src/components/Dropdown/Toggle.tsx 55.55% <0%> (-2.59%) ⬇️
...react-core/src/components/Dropdown/KebabToggle.tsx 93.33% <100%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b461c0...f530220. Read the comment docs.

Copy link
Member

@dlabrecq dlabrecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've encountered similar problems in Cost Management where I had to catch the event myself and call event.preventDefault.

@redallen redallen merged commit 2563ce6 into patternfly:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(data-list): Keyboard selection of action causes data list item selection

6 participants