Skip to content

Conversation

@jschuler
Copy link
Collaborator

What: Closes #3508

@patternfly-build
Copy link
Collaborator

patternfly-build commented Feb 25, 2020

@codecov-io
Copy link

codecov-io commented Feb 25, 2020

Codecov Report

Merging #3828 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3828      +/-   ##
==========================================
+ Coverage      71%   71.05%   +0.05%     
==========================================
  Files         785      785              
  Lines       10638    10638              
  Branches     2314     2314              
==========================================
+ Hits         7553     7559       +6     
+ Misses       2655     2654       -1     
+ Partials      430      425       -5
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 85.89% <ø> (ø) ⬆️
#patternfly4 60.11% <ø> (+0.09%) ⬆️
Impacted Files Coverage Δ
...ct-core/src/components/DataToolbar/DataToolbar.tsx 82.85% <0%> (+14.28%) ⬆️
...mponents/OverflowMenu/OverflowMenuDropdownItem.tsx 50% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f7ee95...a4c7fd4. Read the comment docs.

Copy link
Member

@ddonahue007 ddonahue007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@evwilkin evwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@redallen redallen merged commit b6241e1 into patternfly:master Feb 26, 2020
@patternfly-build
Copy link
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.4.15
  • @patternfly/react-core@3.141.3
  • @patternfly/react-docs@4.20.17
  • @patternfly/react-inline-edit-extension@2.17.15
  • demo-app-ts@3.25.3
  • @patternfly/react-table@2.27.15
  • @patternfly/react-topology@2.14.15
  • @patternfly/react-virtualized-extension@1.4.16

Thanks for your contribution! 🎉

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.05%. Comparing base (7b461c0) to head (a4c7fd4).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3828      +/-   ##
==========================================
+ Coverage   71.00%   71.05%   +0.05%     
==========================================
  Files         785      785              
  Lines       10638    10638              
  Branches     2314     2314              
==========================================
+ Hits         7553     7559       +6     
+ Misses       2655     2654       -1     
+ Partials      430      425       -5     
Flag Coverage Δ
misc 95.45% <ø> (ø)
patternfly3 85.89% <ø> (ø)
patternfly4 60.11% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b461c0...a4c7fd4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automate snapshot generation for test coverage

7 participants