Skip to content

Conversation

@dgutride
Copy link
Member

What: Closes #3753
Updates the parent readme for the project with new content

@dgutride dgutride requested a review from tlabaj February 26, 2020 21:27
@patternfly-build
Copy link
Collaborator

patternfly-build commented Feb 26, 2020

README.md Outdated
* TypeScript: [Fork and clone the PatternFly React Seed project](https://github.com/patternfly/patternfly-react-seed).
* JavaScript: [Fork and clone the JavaScript branch of the PatternFly React Seed project](https://github.com/patternfly/patternfly-react-seed/tree/javascript).

For more information about how to fork and clone a repo, [view GitHub Help](https://help.github.com/articles/fork-a-repo/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be indented? When I look at the rich text it is not aligned under the "1." I don't know if it should be.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated alignment earlier.

2. **Install the project**

Follow the steps outlined in the [PatternFly React Seed README](https://github.com/patternfly/patternfly-react-seed#quick-start) to install.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question about alignment here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated alignment earlier.

@codecov-io
Copy link

codecov-io commented Feb 26, 2020

Codecov Report

Merging #3837 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3837   +/-   ##
=======================================
  Coverage   71.01%   71.01%           
=======================================
  Files         785      785           
  Lines       10643    10643           
  Branches     2319     2319           
=======================================
  Hits         7558     7558           
  Misses       2655     2655           
  Partials      430      430
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 85.89% <ø> (ø) ⬆️
#patternfly4 60.04% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b10db3...a471fb4. Read the comment docs.

@dgutride
Copy link
Member Author

tlabaj
tlabaj previously approved these changes Feb 27, 2020
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jessiehuff
jessiehuff previously approved these changes Feb 27, 2020
Copy link
Contributor

@jessiehuff jessiehuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

abigaeljamie
abigaeljamie previously approved these changes Feb 27, 2020
Co-Authored-By: abigaeljamie <56559644+abigaeljamie@users.noreply.github.com>
@dgutride dgutride dismissed stale reviews from abigaeljamie, jessiehuff, and tlabaj via 98ad075 February 27, 2020 21:36
dgutride and others added 3 commits February 27, 2020 16:37
Co-Authored-By: abigaeljamie <56559644+abigaeljamie@users.noreply.github.com>
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessiehuff jessiehuff merged commit 0ee8816 into patternfly:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve patternfly-react readme content

6 participants