Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/react-codemods/transforms/pf3-pf4.button.test.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { EOL as SYSTEM_EOL } from 'os';
import prettier from 'prettier';
import { defineInlineTest } from 'jscodeshift/dist/testUtils';
import transform from './pf3-pf4';
Expand Down
2 changes: 1 addition & 1 deletion packages/react-codemods/transforms/pf3-pf4.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable no-console */
/* eslint-disable no-console,jsdoc/require-jsdoc */
const colors = require('colors');
const componentConfigs = require('../componentConfig');

Expand Down
1 change: 0 additions & 1 deletion packages/react-codemods/transforms/pf3-pf4.test.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { EOL as SYSTEM_EOL } from 'os';
import prettier from 'prettier';
import { defineInlineTest, runInlineTest } from 'jscodeshift/dist/testUtils';
import transform from './pf3-pf4';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as React from 'react';
import * as ReactDOM from 'react-dom';
import { css } from '@patternfly/react-styles';
import styles from '@patternfly/react-styles/css/components/Backdrop/backdrop';
import { canUseDOM } from 'exenv';
import { canUseDOM } from '../../helpers';
import { KEY_CODES } from '../../helpers/constants';
import { AboutModalContainer } from './AboutModalContainer';
import { PickOptional } from '../../helpers/typeUtils';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as React from 'react';
import * as ReactDOM from 'react-dom';
import { canUseDOM } from 'exenv';
import { canUseDOM } from '../../helpers';
import { Omit } from '../../helpers/typeUtils';
import { AlertGroupInline } from './AlertGroupInline';

Expand Down
3 changes: 1 addition & 2 deletions packages/react-core/src/components/DataList/DataList.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import * as React from 'react';
import { isUndefined } from 'lodash';

import { css } from '@patternfly/react-styles';
import styles from '@patternfly/react-styles/css/components/DataList/data-list';
Expand Down Expand Up @@ -38,7 +37,7 @@ export const DataList: React.FunctionComponent<DataListProps> = ({
isCompact = false,
...props
}: DataListProps) => {
const isSelectable = !isUndefined(onSelectDataListItem);
const isSelectable = onSelectDataListItem !== undefined;

const updateSelectedDataListItem = (id: string) => {
onSelectDataListItem(id);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import * as React from 'react';
import { sum, values } from 'lodash';
import styles from '@patternfly/react-styles/css/components/DataToolbar/data-toolbar';
import { css } from '@patternfly/react-styles';
import { DataToolbarContext } from './DataToolbarUtils';
Expand Down Expand Up @@ -91,7 +90,7 @@ export class DataToolbar extends React.Component<DataToolbarProps, DataToolbarSt
}
};

getNumberOfFilters = () => sum(values(this.state.filterInfo));
getNumberOfFilters = () => Object.values(this.state.filterInfo).reduce((acc, cur) => acc + cur, 0);

render() {
const {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Modal/Modal.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as React from 'react';
import * as ReactDOM from 'react-dom';
import { canUseDOM } from 'exenv';
import { canUseDOM } from '../../helpers';

import { css } from '@patternfly/react-styles';
import styles from '@patternfly/react-styles/css/components/Backdrop/backdrop';
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Tabs/Tab.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ export interface TabProps extends Omit<React.HTMLProps<HTMLAnchorElement | HTMLB
tabContentRef?: React.RefObject<any>;
}

export const Tab: React.FunctionComponent<TabProps> = ({ className = '' }: TabProps) => null;
export const Tab: React.FunctionComponent<TabProps> = (_props: TabProps) => null;
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Wizard/Wizard.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as React from 'react';
import * as ReactDOM from 'react-dom';
import { canUseDOM } from 'exenv';
import { canUseDOM } from '../../helpers';
import { KEY_CODES } from '../../helpers/constants';
import { css } from '@patternfly/react-styles';
import styles from '@patternfly/react-styles/css/components/Wizard/wizard';
Expand Down
1 change: 0 additions & 1 deletion packages/react-core/src/components/withOuia/withOuia.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import * as React from 'react';
import { isOUIAEnvironment, getUniqueId, generateOUIAId } from './ouia';
import { Omit } from '../../helpers/typeUtils';

export const OuiaContext = React.createContext<OuiaContextProps | null>(null);

Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/helpers/safeHTMLElement.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// https://github.com/reactjs/react-modal/blob/master/src/helpers/safeHTMLElement.js
import { canUseDOM } from 'exenv';
import { canUseDOM } from './util';

export default canUseDOM ? window.HTMLElement : {};
2 changes: 2 additions & 0 deletions packages/react-core/src/helpers/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -247,3 +247,5 @@ export const formatBreakpointMods = (
`${acc}${acc && ' '}${getModifier(styles, `${curr.modifier}${curr.breakpoint ? `-on-${curr.breakpoint}` : ''}`)}`,
''
);

export const canUseDOM = !!(typeof window !== 'undefined' && window.document && window.document.createElement);
1 change: 1 addition & 0 deletions packages/react-icons/src/createIcon.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ const createIcon = iconDefinition => {
id = `icon-title-${currentId++}`;

render() {
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const { size, color, title, noStyle, noVerticalAlign, ...props } = this.props;

const hasTitle = Boolean(title);
Expand Down