Skip to content

destructure bubbleEvent from props to avoid it passing to button el #3894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 3 commits into from
Mar 9, 2020
Merged

destructure bubbleEvent from props to avoid it passing to button el #3894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
598a311
destructure bubbleEvent from props to avoid it passing to button el
evwilkin Mar 9, 2020
9fbbb3e
updated snapshots
evwilkin Mar 9, 2020
0ba1077
updated Table snapshot
evwilkin Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .../components/ApplicationLauncher/__tests__/__snapshots__/ApplicationLauncher.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,6 @@ exports[`ApplicationLauncher custom icon 1`] = `
aria-expanded={true}
aria-haspopup={true}
aria-label="Application launcher"
bubbleEvent={false}
className="pf-c-app-launcher__toggle"
disabled={false}
id="pf-toggle-id-5"
Expand Down Expand Up @@ -1215,7 +1214,6 @@ exports[`ApplicationLauncher dropup + right aligned 1`] = `
aria-expanded={false}
aria-haspopup={true}
aria-label="Application launcher"
bubbleEvent={false}
className="pf-c-app-launcher__toggle"
disabled={false}
id="pf-toggle-id-3"
Expand Down Expand Up @@ -1605,7 +1603,6 @@ exports[`ApplicationLauncher dropup 1`] = `
aria-expanded={false}
aria-haspopup={true}
aria-label="Application launcher"
bubbleEvent={false}
className="pf-c-app-launcher__toggle"
disabled={false}
id="pf-toggle-id-2"
Expand Down Expand Up @@ -2155,7 +2152,6 @@ exports[`ApplicationLauncher expanded 1`] = `
aria-expanded={true}
aria-haspopup={true}
aria-label="Application launcher"
bubbleEvent={false}
className="pf-c-app-launcher__toggle"
disabled={false}
id="pf-toggle-id-4"
Expand Down Expand Up @@ -2860,7 +2856,6 @@ exports[`ApplicationLauncher regular 1`] = `
aria-expanded={false}
aria-haspopup={true}
aria-label="Application launcher"
bubbleEvent={false}
className="pf-c-app-launcher__toggle"
disabled={false}
id="pf-toggle-id-0"
Expand Down Expand Up @@ -3250,7 +3245,6 @@ exports[`ApplicationLauncher right aligned 1`] = `
aria-expanded={false}
aria-haspopup={true}
aria-label="Application launcher"
bubbleEvent={false}
className="pf-c-app-launcher__toggle"
disabled={false}
id="pf-toggle-id-1"
Expand Down
2 changes: 2 additions & 0 deletions packages/react-core/src/components/Dropdown/Toggle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ export class Toggle extends React.Component<ToggleProps> {
isPrimary,
isSplitButton,
ariaHasPopup,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
bubbleEvent,
onToggle,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
onEnter,
Expand Down
14 changes: 0 additions & 14 deletions packages/react-core/src/components/Dropdown/__tests__/__snapshots__/Dropdown.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@ exports[`KebabToggle basic 1`] = `
aria-expanded={true}
aria-haspopup={false}
aria-label="Actions"
bubbleEvent={false}
className="pf-c-dropdown__toggle"
disabled={false}
id="Dropdown Toggle"
Expand Down Expand Up @@ -899,7 +898,6 @@ exports[`KebabToggle dropup + right aligned 1`] = `
aria-expanded={false}
aria-haspopup={true}
aria-label="Actions"
bubbleEvent={false}
className="pf-c-dropdown__toggle"
disabled={false}
id="Dropdown Toggle"
Expand Down Expand Up @@ -1610,7 +1608,6 @@ exports[`KebabToggle dropup 1`] = `
aria-expanded={false}
aria-haspopup={true}
aria-label="Actions"
bubbleEvent={false}
className="pf-c-dropdown__toggle"
disabled={false}
id="Dropdown Toggle"
Expand Down Expand Up @@ -2471,7 +2468,6 @@ exports[`KebabToggle expanded 1`] = `
aria-expanded={true}
aria-haspopup={true}
aria-label="Actions"
bubbleEvent={false}
className="pf-c-dropdown__toggle"
disabled={false}
id="Dropdown Toggle"
Expand Down Expand Up @@ -3451,7 +3447,6 @@ exports[`KebabToggle plain 1`] = `
aria-expanded={false}
aria-haspopup={true}
aria-label="Actions"
bubbleEvent={false}
className="pf-c-dropdown__toggle pf-m-plain"
disabled={false}
id="Dropdown Toggle"
Expand Down Expand Up @@ -4159,7 +4154,6 @@ exports[`KebabToggle regular 1`] = `
aria-expanded={false}
aria-haspopup={true}
aria-label="Actions"
bubbleEvent={false}
className="pf-c-dropdown__toggle"
disabled={false}
id="Dropdown Toggle"
Expand Down Expand Up @@ -4870,7 +4864,6 @@ exports[`KebabToggle right aligned 1`] = `
aria-expanded={false}
aria-haspopup={true}
aria-label="Actions"
bubbleEvent={false}
className="pf-c-dropdown__toggle"
disabled={false}
id="Dropdown Toggle"
Expand Down Expand Up @@ -5093,7 +5086,6 @@ exports[`dropdown basic 1`] = `
<button
aria-expanded={true}
aria-haspopup={false}
bubbleEvent={false}
className="pf-c-dropdown__toggle"
disabled={false}
id="Dropdown Toggle"
Expand Down Expand Up @@ -5852,7 +5844,6 @@ exports[`dropdown dropup + right aligned 1`] = `
<button
aria-expanded={false}
aria-haspopup={true}
bubbleEvent={false}
className="pf-c-dropdown__toggle"
disabled={false}
id="Dropdown Toggle"
Expand Down Expand Up @@ -6586,7 +6577,6 @@ exports[`dropdown dropup 1`] = `
<button
aria-expanded={false}
aria-haspopup={true}
bubbleEvent={false}
className="pf-c-dropdown__toggle"
disabled={false}
id="Dropdown Toggle"
Expand Down Expand Up @@ -7470,7 +7460,6 @@ exports[`dropdown expanded 1`] = `
<button
aria-expanded={true}
aria-haspopup={true}
bubbleEvent={false}
className="pf-c-dropdown__toggle"
disabled={false}
id="Dropdown Toggle"
Expand Down Expand Up @@ -8475,7 +8464,6 @@ exports[`dropdown primary 1`] = `
<button
aria-expanded={false}
aria-haspopup={true}
bubbleEvent={false}
className="pf-c-dropdown__toggle pf-m-primary"
disabled={false}
id="Dropdown Toggle"
Expand Down Expand Up @@ -9206,7 +9194,6 @@ exports[`dropdown regular 1`] = `
<button
aria-expanded={false}
aria-haspopup={true}
bubbleEvent={false}
className="pf-c-dropdown__toggle"
disabled={false}
id="Dropdown Toggle"
Expand Down Expand Up @@ -9940,7 +9927,6 @@ exports[`dropdown right aligned 1`] = `
<button
aria-expanded={false}
aria-haspopup={true}
bubbleEvent={false}
className="pf-c-dropdown__toggle"
disabled={false}
id="Dropdown Toggle"
Expand Down
5 changes: 0 additions & 5 deletions ...s/react-core/src/components/Dropdown/__tests__/__snapshots__/DropdownToggle.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ exports[`state active 1`] = `
>
<button
aria-expanded={false}
bubbleEvent={false}
className="pf-c-dropdown__toggle pf-m-active"
disabled={false}
id="Dropdown Toggle"
Expand Down Expand Up @@ -94,7 +93,6 @@ exports[`state class changes 1`] = `
>
<button
aria-expanded={false}
bubbleEvent={false}
className="pf-c-dropdown__toggle pf-m-focus"
disabled={false}
id="Dropdown Toggle"
Expand Down Expand Up @@ -164,7 +162,6 @@ exports[`state class changes 2`] = `
>
<button
aria-expanded={false}
bubbleEvent={false}
className="pf-c-dropdown__toggle pf-m-focus"
disabled={false}
id="Dropdown Toggle"
Expand Down Expand Up @@ -234,7 +231,6 @@ exports[`state focus 1`] = `
>
<button
aria-expanded={false}
bubbleEvent={false}
className="pf-c-dropdown__toggle pf-m-focus"
disabled={false}
id="Dropdown Toggle"
Expand Down Expand Up @@ -304,7 +300,6 @@ exports[`state hover 1`] = `
>
<button
aria-expanded={false}
bubbleEvent={false}
className="pf-c-dropdown__toggle pf-m-hover"
disabled={false}
id="Dropdown Toggle"
Expand Down
2 changes: 0 additions & 2 deletions packages/react-core/src/components/Dropdown/__tests__/__snapshots__/Toggle.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ exports[`Dropdown toggle 1`] = `
>
<button
aria-expanded={false}
bubbleEvent={false}
className="pf-c-dropdown__toggle"
disabled={false}
id="Dropdown Toggle"
Expand Down Expand Up @@ -92,7 +91,6 @@ exports[`Kebab toggle 1`] = `
<button
aria-expanded={false}
aria-label="Actions"
bubbleEvent={false}
className="pf-c-dropdown__toggle"
disabled={false}
id="Dropdown Toggle"
Expand Down
7 changes: 0 additions & 7 deletions ...s/react-core/src/components/OptionsMenu/__tests__/__snapshots__/OptionsMenu.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,6 @@ exports[`optionsMenu expanded 1`] = `
aria-expanded={true}
aria-haspopup="listbox"
aria-label="Options menu"
bubbleEvent={false}
className="pf-c-options-menu__toggle"
disabled={false}
id="expanded-toggle"
Expand Down Expand Up @@ -1493,7 +1492,6 @@ exports[`optionsMenu isDisabled 1`] = `
aria-expanded={false}
aria-haspopup="listbox"
aria-label="Options menu"
bubbleEvent={false}
className="pf-c-options-menu__toggle"
disabled={true}
id="disabled-toggle"
Expand Down Expand Up @@ -1891,7 +1889,6 @@ exports[`optionsMenu open up 1`] = `
aria-expanded={false}
aria-haspopup="listbox"
aria-label="Options menu"
bubbleEvent={false}
className="pf-c-options-menu__toggle"
disabled={false}
id="openUp-toggle"
Expand Down Expand Up @@ -2239,7 +2236,6 @@ exports[`optionsMenu plain 1`] = `
aria-expanded={false}
aria-haspopup="listbox"
aria-label="Options menu"
bubbleEvent={false}
className="pf-c-options-menu__toggle pf-m-plain"
disabled={false}
id="plain-toggle"
Expand Down Expand Up @@ -2606,7 +2602,6 @@ exports[`optionsMenu regular 1`] = `
aria-expanded={false}
aria-haspopup="listbox"
aria-label="Options menu"
bubbleEvent={false}
className="pf-c-options-menu__toggle"
disabled={false}
id="regular-toggle"
Expand Down Expand Up @@ -3007,7 +3002,6 @@ exports[`optionsMenu right aligned + open up 1`] = `
aria-expanded={false}
aria-haspopup="listbox"
aria-label="Options menu"
bubbleEvent={false}
className="pf-c-options-menu__toggle"
disabled={false}
id="rightAlignedOpenUp-toggle"
Expand Down Expand Up @@ -3405,7 +3399,6 @@ exports[`optionsMenu right aligned 1`] = `
aria-expanded={false}
aria-haspopup="listbox"
aria-label="Options menu"
bubbleEvent={false}
className="pf-c-options-menu__toggle"
disabled={false}
id="rightAligned-toggle"
Expand Down
13 changes: 0 additions & 13 deletions ...ges/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,6 @@ exports[`component render custom pagination toggle 1`] = `
<button
aria-expanded={false}
aria-label="Items per page"
bubbleEvent={false}
className=" pf-c-options-menu__toggle-button"
disabled={false}
id="pagination-options-menu-toggle-11"
Expand Down Expand Up @@ -1542,7 +1541,6 @@ exports[`component render custom perPageOptions 1`] = `
<button
aria-expanded={false}
aria-label="Items per page"
bubbleEvent={false}
className=" pf-c-options-menu__toggle-button"
disabled={false}
id="pagination-options-menu-toggle-7"
Expand Down Expand Up @@ -2638,7 +2636,6 @@ exports[`component render custom start end 1`] = `
<button
aria-expanded={false}
aria-label="Items per page"
bubbleEvent={false}
className=" pf-c-options-menu__toggle-button"
disabled={false}
id="pagination-options-menu-toggle-9"
Expand Down Expand Up @@ -4365,7 +4362,6 @@ exports[`component render last page 1`] = `
<button
aria-expanded={false}
aria-label="Items per page"
bubbleEvent={false}
className=" pf-c-options-menu__toggle-button"
disabled={false}
id="pagination-options-menu-toggle-6"
Expand Down Expand Up @@ -5459,7 +5455,6 @@ exports[`component render limited number of pages 1`] = `
<button
aria-expanded={false}
aria-label="Items per page"
bubbleEvent={false}
className=" pf-c-options-menu__toggle-button"
disabled={false}
id="pagination-options-menu-toggle-4"
Expand Down Expand Up @@ -6554,7 +6549,6 @@ exports[`component render no items 1`] = `
<button
aria-expanded={false}
aria-label="Items per page"
bubbleEvent={false}
className=" pf-c-options-menu__toggle-button"
disabled={true}
id="pagination-options-menu-toggle-8"
Expand Down Expand Up @@ -7626,7 +7620,6 @@ exports[`component render should render correctly bottom 1`] = `
<button
aria-expanded={false}
aria-label="Items per page"
bubbleEvent={false}
className=" pf-c-options-menu__toggle-button"
disabled={false}
id="pagination-options-menu-toggle-1"
Expand Down Expand Up @@ -8720,7 +8713,6 @@ exports[`component render should render correctly compact 1`] = `
<button
aria-expanded={false}
aria-label="Items per page"
bubbleEvent={false}
className=" pf-c-options-menu__toggle-button"
disabled={false}
id="pagination-options-menu-toggle-2"
Expand Down Expand Up @@ -9628,7 +9620,6 @@ exports[`component render should render correctly disabled 1`] = `
<button
aria-expanded={false}
aria-label="Items per page"
bubbleEvent={false}
className=" pf-c-options-menu__toggle-button"
disabled={true}
id="pagination-options-menu-toggle-3"
Expand Down Expand Up @@ -10720,7 +10711,6 @@ exports[`component render should render correctly top 1`] = `
<button
aria-expanded={false}
aria-label="Items per page"
bubbleEvent={false}
className=" pf-c-options-menu__toggle-button"
disabled={false}
id="pagination-options-menu-toggle-0"
Expand Down Expand Up @@ -11815,7 +11805,6 @@ exports[`component render titles 1`] = `
<button
aria-expanded={false}
aria-label="Select"
bubbleEvent={false}
className=" pf-c-options-menu__toggle-button"
disabled={false}
id="pagination-options-menu-toggle-10"
Expand Down Expand Up @@ -12909,7 +12898,6 @@ exports[`component render up drop direction 1`] = `
<button
aria-expanded={false}
aria-label="Items per page"
bubbleEvent={false}
className=" pf-c-options-menu__toggle-button"
disabled={false}
id="pagination-options-menu-toggle-12"
Expand Down Expand Up @@ -14004,7 +13992,6 @@ exports[`component render zero results 1`] = `
<button
aria-expanded={false}
aria-label="Items per page"
bubbleEvent={false}
className=" pf-c-options-menu__toggle-button"
disabled={true}
id="pagination-options-menu-toggle-5"
Expand Down
Loading