fix(core,table): forward ref types

packages/react-catalog-view-extension/package.json

@@ -62,11 +62,11 @@
     "node-sass": "^4.12.0",
     "rimraf": "^2.6.2",
     "shx": "^0.3.2",
-    "typescript": "3.4.5"
+    "typescript": "^3.8.3"
   },
   "peerDependencies": {
     "prop-types": "^15.6.1",
     "react": "^16.4.0",
     "react-dom": "^15.6.2 || ^16.4.0"
   }
-}
+}

packages/react-catalog-view-extension/src/components/CatalogItemHeader/CatalogItemHeader.tsx

@@ -1,8 +1,6 @@
 import * as React from 'react';
 import classNames from 'classnames';
 
-import { Omit } from '../../helpers/typeUtils';
-
 export interface CatalogItemHeaderProps extends Omit<React.HTMLProps<HTMLElement>, 'title'> {
   /** Additional css classes */
   className?: string;

packages/react-catalog-view-extension/src/components/CatalogTile/CatalogTile.tsx

@@ -7,7 +7,6 @@ import { CardBody } from '@patternfly/react-core/dist/js/components/Card/CardBod
 import { CardFooter } from '@patternfly/react-core/dist/js/components/Card/CardFooter';
 import classNames from 'classnames';
 
-import { Omit } from '../../helpers/typeUtils';
 export interface CatalogTileProps extends Omit<React.HTMLProps<HTMLElement>, 'title'> {
   /** Id */
   id?: any;

packages/react-catalog-view-extension/src/components/CatalogTile/CatalogTileBadge.tsx

@@ -2,8 +2,6 @@ import * as React from 'react';
 import { Tooltip } from '@patternfly/react-core';
 import classNames from 'classnames';
 
-import { Omit } from '../../helpers/typeUtils';
-
 export interface CatalogTileBadgeProps extends Omit<React.HTMLProps<HTMLElement>, 'title'> {
   /** Children (typically an Icon) */
   children?: React.ReactNode;

packages/react-catalog-view-extension/src/components/FilterSidePanel/FilterSidePanelCategory.tsx

@@ -5,7 +5,6 @@ import { default as formStyles } from '@patternfly/react-styles/css/components/F
 import { css } from '@patternfly/react-styles';
 
 import { childrenToArray } from '../../helpers/util';
-import { Omit } from '../../helpers/typeUtils';
 
 export interface FilterSidePanelCategoryProps extends Omit<React.HTMLProps<HTMLFormElement>, 'title'> {
   /** Children nodes */

packages/react-catalog-view-extension/src/components/PropertiesSidePanel/PropertyItem.tsx

@@ -1,7 +1,6 @@
 import * as React from 'react';
 import classNames from 'classnames';
 
-import { Omit } from '../../helpers/typeUtils';
 import { Text, TextVariants } from '@patternfly/react-core/dist/js/components/Text/Text';
 
 export interface PropertyItemProps extends Omit<React.HTMLProps<HTMLDivElement>, 'label' | 'value'> {

packages/react-catalog-view-extension/src/components/VerticalTabs/VerticalTabsTab.tsx

@@ -1,8 +1,6 @@
 import * as React from 'react';
 import classNames from 'classnames';
 
-import { Omit } from '../../helpers/typeUtils';
-
 export interface VerticalTabsTabProps extends Omit<React.HTMLProps<HTMLLIElement>, 'title'> {
   /** Child tab nodes (VerticalTabsTab's) */
   children?: React.ReactNode;

packages/react-charts/package.json

@@ -69,6 +69,6 @@
     "fs-extra": "^6.0.1",
     "glob": "^7.1.2",
     "rimraf": "^2.6.2",
-    "typescript": "3.4.5"
+    "typescript": "^3.8.3"
   }
-}
+}

packages/react-charts/src/components/ChartLegend/ChartLegend.tsx

@@ -4,7 +4,6 @@ import {
   BlockProps,
   ColorScalePropType,
   EventPropTypeInterface,
-  Omit,
   OrientationTypes,
   PaddingProps,
   StringOrNumberOrCallback,

packages/react-charts/src/declarations.d.ts

@@ -5,3 +5,8 @@ declare module 'victory-core' {
   export const Path: any;
   export const TextSize: any;
 }
+
+declare module 'hoist-non-react-statics' {
+  const hoist: any;
+  export default hoist;
+}

packages/react-core/package.json

@@ -70,12 +70,12 @@
     "generator-tsx-docgen": "^0.1.0",
     "glob": "^7.1.2",
     "rimraf": "^2.6.2",
-    "typescript": "3.4.5",
+    "typescript": "^3.8.3",
     "yo": "^3.1.1"
   },
   "peerDependencies": {
     "prop-types": "^15.6.1",
     "react": "^16.4.0",
     "react-dom": "^15.6.2 || ^16.4.0"
   }
-}
+}

packages/react-core/src/components/Accordion/AccordionToggle.tsx

@@ -2,7 +2,6 @@ import * as React from 'react';
 import { css } from '@patternfly/react-styles';
 import styles from '@patternfly/react-styles/css/components/Accordion/accordion';
 import AngleRightIcon from '@patternfly/react-icons/dist/js/icons/angle-right-icon';
-import { Omit } from '../../helpers/typeUtils';
 import { AccordionContext } from './AccordionContext';
 
 export interface AccordionToggleProps extends Omit<React.HTMLProps<HTMLButtonElement>, 'type'> {

packages/react-core/src/components/Alert/Alert.tsx

@@ -4,7 +4,6 @@ import styles from '@patternfly/react-styles/css/components/Alert/alert';
 import accessibleStyles from '@patternfly/react-styles/css/utilities/Accessibility/accessibility';
 import { AlertIcon } from './AlertIcon';
 import { capitalize } from '../../helpers/util';
-import { Omit } from '../../helpers/typeUtils';
 import { InjectedOuiaProps, withOuiaContext } from '../withOuia';
 
 export enum AlertVariant {

packages/react-core/src/components/AlertGroup/AlertGroup.tsx

@@ -1,7 +1,6 @@
 import * as React from 'react';
 import * as ReactDOM from 'react-dom';
 import { canUseDOM } from '../../helpers';
-import { Omit } from '../../helpers/typeUtils';
 import { AlertGroupInline } from './AlertGroupInline';
 
 export interface AlertGroupProps extends Omit<React.HTMLProps<HTMLUListElement>, 'className'> {

packages/react-core/src/components/BackgroundImage/BackgroundImage.tsx

@@ -1,5 +1,4 @@
 import * as React from 'react';
-import { Omit } from '../../helpers/typeUtils';
 
 import { css, StyleSheet } from '@patternfly/react-styles';
 import styles from '@patternfly/react-styles/css/components/BackgroundImage/background-image';

packages/react-core/src/components/Checkbox/Checkbox.tsx

@@ -1,7 +1,7 @@
 import * as React from 'react';
 import styles from '@patternfly/react-styles/css/components/Check/check';
 import { css, getModifier } from '@patternfly/react-styles';
-import { Omit, PickOptional } from '../../helpers/typeUtils';
+import { PickOptional } from '../../helpers/typeUtils';
 
 export interface CheckboxProps
   extends Omit<React.HTMLProps<HTMLInputElement>, 'type' | 'onChange' | 'disabled' | 'label'> {

packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx

@@ -1,7 +1,7 @@
 import * as React from 'react';
 import styles from '@patternfly/react-styles/css/components/ClipboardCopy/clipboard-copy';
 import { css } from '@patternfly/react-styles';
-import { Omit, PickOptional } from '../../helpers/typeUtils';
+import { PickOptional } from '../../helpers/typeUtils';
 import { PopoverPosition } from '../Popover';
 import { TextInput } from '../TextInput';
 import { TooltipPosition } from '../Tooltip';

packages/react-core/src/components/ClipboardCopy/ClipboardCopyExpanded.tsx

@@ -2,7 +2,7 @@ import * as React from 'react';
 import styles from '@patternfly/react-styles/css/components/ClipboardCopy/clipboard-copy';
 import { css } from '@patternfly/react-styles';
 import { ClipboardCopyProps } from './ClipboardCopy';
-import { Omit, PickOptional } from '../../helpers/typeUtils';
+import { PickOptional } from '../../helpers/typeUtils';
 
 export interface ClipboardCopyExpandedProps extends Omit<ClipboardCopyProps, 'onChange'> {
   className?: string;

packages/react-core/src/components/DataList/DataListAction.tsx

@@ -1,7 +1,7 @@
 import * as React from 'react';
 import { css, pickProperties } from '@patternfly/react-styles';
 import styles from '@patternfly/react-styles/css/components/DataList/data-list';
-import { Omit, PickOptional } from '../../helpers/typeUtils';
+import { PickOptional } from '../../helpers/typeUtils';
 
 const visibilityModifiers = pickProperties(styles.modifiers, [
   'hidden',

packages/react-core/src/components/DataList/DataListCell.tsx

@@ -1,7 +1,6 @@
 import * as React from 'react';
 import { css, getModifier } from '@patternfly/react-styles';
 import styles from '@patternfly/react-styles/css/components/DataList/data-list';
-import { Omit } from '../../helpers/typeUtils';
 
 export interface DataListCellProps extends Omit<React.HTMLProps<HTMLDivElement>, 'width'> {
   /** Content rendered inside the DataList cell */

packages/react-core/src/components/DataList/DataListCheck.tsx

@@ -1,7 +1,6 @@
 import * as React from 'react';
 import { css } from '@patternfly/react-styles';
 import styles from '@patternfly/react-styles/css/components/DataList/data-list';
-import { Omit } from '../../helpers/typeUtils';
 
 export interface DataListCheckProps extends Omit<React.HTMLProps<HTMLInputElement>, 'onChange' | 'checked'> {
   /** Additional classes added to the DataList item checkbox */

packages/react-core/src/components/DataList/DataListItem.tsx

@@ -1,7 +1,6 @@
 import * as React from 'react';
 import { css } from '@patternfly/react-styles';
 import styles from '@patternfly/react-styles/css/components/DataList/data-list';
-import { Omit } from '../../helpers/typeUtils';
 import { DataListContext } from './DataList';
 import { KeyTypes } from '../Select';
 

packages/react-core/src/components/DataList/DataListItemRow.tsx

@@ -1,7 +1,6 @@
 import * as React from 'react';
 import { css } from '@patternfly/react-styles';
 import styles from '@patternfly/react-styles/css/components/DataList/data-list';
-import { Omit } from '../../helpers/typeUtils';
 
 export interface DataListItemRowProps extends Omit<React.HTMLProps<HTMLDivElement>, 'children'> {
   children: React.ReactNode;

packages/react-core/src/components/DataToolbar/DataToolbarGroup.tsx

@@ -1,7 +1,6 @@
 import * as React from 'react';
 import styles from '@patternfly/react-styles/css/components/DataToolbar/data-toolbar';
 import { css, getModifier } from '@patternfly/react-styles';
-import { Omit } from '../../helpers/typeUtils';
 import { DataToolbarBreakpointMod } from './DataToolbarUtils';
 import { formatBreakpointMods } from '../../helpers/util';
 import { RefObject } from 'react';

packages/react-core/src/components/Dropdown/DropdownGroup.tsx

@@ -1,7 +1,6 @@
 import * as React from 'react';
 import { css } from '@patternfly/react-styles';
 import { DropdownContext } from './dropdownConstants';
-import { Omit } from '../../helpers/typeUtils';
 
 export interface DropdownGroupProps extends Omit<React.HTMLProps<HTMLDivElement>, 'label'> {
   /** Checkboxes within group */

packages/react-core/src/components/Dropdown/DropdownToggleCheckbox.tsx

@@ -1,7 +1,7 @@
 import * as React from 'react';
 import styles from '@patternfly/react-styles/css/components/Dropdown/dropdown';
 import { css } from '@patternfly/react-styles';
-import { Omit, PickOptional } from '../../helpers/typeUtils';
+import { PickOptional } from '../../helpers/typeUtils';
 
 export interface DropdownToggleCheckboxProps
   extends Omit<React.HTMLProps<HTMLInputElement>, 'type' | 'onChange' | 'disabled' | 'checked'> {

packages/react-core/src/components/EmptyState/EmptyStateIcon.tsx

@@ -1,7 +1,6 @@
 import * as React from 'react';
 import { css } from '@patternfly/react-styles';
 import styles from '@patternfly/react-styles/css/components/EmptyState/empty-state';
-import { Omit } from '../../helpers/typeUtils';
 
 export enum IconSize {
   sm = 'sm',

packages/react-core/src/components/FileUpload/FileUpload.tsx

@@ -1,6 +1,5 @@
 import * as React from 'react';
 import Dropzone, { DropzoneProps, DropFileEventHandler } from 'react-dropzone';
-import { Omit } from '../../helpers';
 import { FileUploadField, FileUploadFieldProps } from './FileUploadField';
 import { readFile, fileReaderType } from '../../helpers/fileUtils';
 

packages/react-core/src/components/FileUpload/FileUploadField.tsx

@@ -1,7 +1,6 @@
 import * as React from 'react';
 import styles from '@patternfly/react-styles/css/components/FileUpload/file-upload';
 import { css } from '@patternfly/react-styles';
-import { Omit } from '../../helpers';
 import { InputGroup } from '../InputGroup';
 import { TextInput } from '../TextInput';
 import { Button, ButtonVariant } from '../Button';

packages/react-core/src/components/Form/FormGroup.tsx

@@ -1,5 +1,4 @@
 import * as React from 'react';
-import { Omit } from '../../helpers/typeUtils';
 import styles from '@patternfly/react-styles/css/components/Form/form';
 import { ASTERISK } from '../../helpers/htmlConstants';
 import { FormContext } from './FormContext';

packages/react-core/src/components/FormSelect/FormSelect.tsx

@@ -1,7 +1,7 @@
 import * as React from 'react';
 import styles from '@patternfly/react-styles/css/components/FormControl/form-control';
 import { css } from '@patternfly/react-styles';
-import { Omit, PickOptional } from '../../helpers/typeUtils';
+import { PickOptional } from '../../helpers/typeUtils';
 import { ValidatedOptions } from '../../helpers/constants';
 
 export interface FormSelectProps

packages/react-core/src/components/FormSelect/FormSelectOption.tsx

@@ -1,5 +1,4 @@
 import * as React from 'react';
-import { Omit } from '../../helpers/typeUtils';
 
 export interface FormSelectOptionProps extends Omit<React.HTMLProps<HTMLOptionElement>, 'disabled'> {
   /** additional classes added to the Select Option */

packages/react-core/src/components/FormSelect/FormSelectOptionGroup.tsx

@@ -1,5 +1,4 @@
 import * as React from 'react';
-import { Omit } from '../../helpers/typeUtils';
 
 export interface FormSelectOptionGroupProps extends Omit<React.HTMLProps<HTMLOptGroupElement>, 'disabled'> {
   /** content rendered inside the Select Option Group */

packages/react-core/src/components/List/List.tsx

@@ -1,7 +1,6 @@
 import * as React from 'react';
 import styles from '@patternfly/react-styles/css/components/List/list';
 import { css, getModifier } from '@patternfly/react-styles';
-import { Omit } from '../../helpers/typeUtils';
 
 export enum OrderType {
   number = '1',

packages/react-core/src/components/Nav/Nav.tsx

@@ -2,7 +2,6 @@ import * as React from 'react';
 import styles from '@patternfly/react-styles/css/components/Nav/nav';
 import { css } from '@patternfly/react-styles';
 import { InjectedOuiaProps, withOuiaContext } from '../withOuia';
-import { Omit } from '../../helpers/typeUtils';
 
 export type NavSelectClickHandler = (
   e: React.FormEvent<HTMLInputElement>,

packages/react-core/src/components/Nav/NavItem.tsx

@@ -1,7 +1,6 @@
 import * as React from 'react';
 import styles from '@patternfly/react-styles/css/components/Nav/nav';
 import { css } from '@patternfly/react-styles';
-import { Omit } from '../../helpers/typeUtils';
 import { NavContext, NavSelectClickHandler } from './Nav';
 
 export interface NavItemProps extends Omit<React.HTMLProps<HTMLAnchorElement>, 'onClick'> {

packages/react-core/src/components/OptionsMenu/OptionsMenuItem.tsx

@@ -3,7 +3,6 @@ import { css } from '@patternfly/react-styles';
 import styles from '@patternfly/react-styles/css/components/OptionsMenu/options-menu';
 import { DropdownItem } from '../Dropdown';
 import CheckIcon from '@patternfly/react-icons/dist/js/icons/check-icon';
-import { Omit } from '../../helpers/typeUtils';
 
 export interface OptionsMenuItemProps
   extends Omit<React.HTMLProps<HTMLAnchorElement>, 'onSelect' | 'onClick' | 'onKeyDown' | 'type'> {

packages/react-core/src/components/Popover/PopoverHeader.tsx

@@ -1,6 +1,5 @@
 import * as React from 'react';
 import { Title, TitleSize } from '../Title';
-import { Omit } from '../../helpers/typeUtils';
 
 export const PopoverHeader: React.FunctionComponent<PopoverHeaderProps> = ({
   children,

packages/react-core/src/components/Progress/Progress.tsx

@@ -3,7 +3,6 @@ import styles from '@patternfly/react-styles/css/components/Progress/progress';
 import { css, getModifier } from '@patternfly/react-styles';
 import { ProgressContainer, ProgressMeasureLocation, ProgressVariant } from './ProgressContainer';
 import { getUniqueId } from '../../helpers/util';
-import { Omit } from '../../helpers/typeUtils';
 
 export enum ProgressSize {
   sm = 'sm',

packages/react-core/src/components/Progress/ProgressContainer.tsx

@@ -4,7 +4,6 @@ import { css } from '@patternfly/react-styles';
 import CheckCircleIcon from '@patternfly/react-icons/dist/js/icons/check-circle-icon';
 import TimesCircleIcon from '@patternfly/react-icons/dist/js/icons/times-circle-icon';
 import { AriaProps, ProgressBar } from './ProgressBar';
-import { Omit } from '../../helpers/typeUtils';
 
 export enum ProgressMeasureLocation {
   outside = 'outside',

packages/react-core/src/components/Radio/Radio.tsx

@@ -1,7 +1,7 @@
 import * as React from 'react';
 import styles from '@patternfly/react-styles/css/components/Radio/radio';
 import { css, getModifier } from '@patternfly/react-styles';
-import { Omit, PickOptional } from '../../helpers/typeUtils';
+import { PickOptional } from '../../helpers/typeUtils';
 
 export interface RadioProps
   extends Omit<React.HTMLProps<HTMLInputElement>, 'disabled' | 'label' | 'onChange' | 'type'> {

packages/react-core/src/components/Select/Select.tsx

@@ -11,7 +11,7 @@ import { SelectToggle } from './SelectToggle';
 import { SelectContext, SelectVariant, SelectDirection, KeyTypes } from './selectConstants';
 import { Chip, ChipGroup } from '../ChipGroup';
 import { keyHandler, getNextIndex } from '../../helpers/util';
-import { Omit, PickOptional } from '../../helpers/typeUtils';
+import { PickOptional } from '../../helpers/typeUtils';
 import { InjectedOuiaProps, withOuiaContext } from '../withOuia';
 import { Divider } from '../Divider';
 

packages/react-core/src/components/Select/SelectMenu.tsx

@@ -4,7 +4,7 @@ import { default as formStyles } from '@patternfly/react-styles/css/components/F
 import { css } from '@patternfly/react-styles';
 import { SelectOptionObject, SelectOption } from './SelectOption';
 import { SelectConsumer, SelectVariant } from './selectConstants';
-import { Omit, PickOptional } from '../../helpers/typeUtils';
+import { PickOptional } from '../../helpers/typeUtils';
 
 // eslint-disable-next-line @typescript-eslint/no-var-requires
 const FocusTrap: any = require('focus-trap-react');

packages/react-core/src/components/Select/SelectOption.tsx

@@ -4,7 +4,6 @@ import { default as checkStyles } from '@patternfly/react-styles/css/components/
 import { css } from '@patternfly/react-styles';
 import CheckIcon from '@patternfly/react-icons/dist/js/icons/check-icon';
 import { SelectConsumer, SelectVariant, KeyTypes } from './selectConstants';
-import { Omit } from '../../helpers/typeUtils';
 
 export interface SelectOptionObject {
   /** Function returns a string to represent the select option object */

packages/react-core/src/components/SimpleList/SimpleList.tsx

@@ -3,7 +3,6 @@ import { css } from '@patternfly/react-styles';
 import styles from '@patternfly/react-styles/css/components/SimpleList/simple-list';
 import { SimpleListGroup } from './SimpleListGroup';
 import { SimpleListItemProps } from './SimpleListItem';
-import { Omit } from '../../helpers/typeUtils';
 
 export interface SimpleListProps extends Omit<React.HTMLProps<HTMLDivElement>, 'onSelect'> {
   /** Content rendered inside the SimpleList */

packages/react-core/src/components/SimpleList/SimpleListGroup.tsx

@@ -1,7 +1,6 @@
 import * as React from 'react';
 import { css } from '@patternfly/react-styles';
 import styles from '@patternfly/react-styles/css/components/SimpleList/simple-list';
-import { Omit } from '../../helpers/typeUtils';
 
 export interface SimpleListGroupProps extends Omit<React.HTMLProps<HTMLTableSectionElement>, 'title'> {
   /** Content rendered inside the SimpleList group */