Skip to content

Empty state width #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
evwilkin merged 3 commits into from
Mar 23, 2020
Merged

Empty state width #3933

evwilkin merged 3 commits into from
Mar 23, 2020

Conversation

@tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Mar 19, 2020 •
edited
Loading

Change the default width to full instead of large. updated the variant name to be more consistent with other components. Note: The variant full was not changed to allow for flexibility of other sizes being added that are larger than xl.
What: Closes #3221 #3873

Breaking changes

  1. Changes the default width to full instead of large. To maintain the previous default behaviour, set the variant prop to large. e.g <EmptyState variant={EmptyStateVariant.large}> ...</EmptyState>
  2. Variant small has been updated to sm
  3. Variant large has been updated to lg

@tlabaj tlabaj added the Breaking change 💥 this change requires a major release and has API changes. label Mar 19, 2020
@tlabaj tlabaj requested review from evwilkin and kmcfaul March 19, 2020 13:34
@tlabaj tlabaj changed the base branch from master to v4 March 19, 2020 13:36
@patternfly-build
Copy link
Collaborator

patternfly-build commented Mar 19, 2020 •
edited
Loading

PF4 preview: https://patternfly-react-pr-3933.surge.sh
A11y report: https://patternfly-react-pr-3933-coverage.surge.sh

@tlabaj tlabaj requested review from dlabrecq and jschuler March 19, 2020 16:08
evwilkin
evwilkin approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@evwilkin evwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evwilkin evwilkin merged commit c104df9 into patternfly:v4 Mar 23, 2020
This was referenced Mar 23, 2020
Closed
Closed
@patternfly-build
Copy link
Collaborator

patternfly-build commented Mar 23, 2020

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@4.0.7
  • @patternfly/react-core@4.0.8
  • @patternfly/react-docs@5.0.6
  • @patternfly/react-inline-edit-extension@4.0.8
  • demo-app-ts@4.0.4
  • @patternfly/react-integration@4.0.6
  • @patternfly/react-table@4.0.8
  • @patternfly/react-topology@4.0.8
  • @patternfly/react-virtualized-extension@4.0.8

Thanks for your contribution! 🎉

redallen added a commit that referenced this pull request May 15, 2020
@redallen @patternfly-build
@evwilkin @dlabrecq @tlabaj @kmcfaul @dlabaj @mturley @boaz0 @jenny-s51 @seanforyou23 @jessiehuff @andybraren @rebeccaalpert @jschuler @jeff-phillips-18 @wojta @nicolethoen @michpetrov @ddonahue007 @dgutride @edewit
feat(master): merge v4 (#4255)
567c0b8 
* chore(packages): publish to prerelease-v4

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.1
 - @patternfly/react-charts@5.3.8
 - @patternfly/react-core@4.0.1
 - @patternfly/react-docs@4.20.25
 - @patternfly/react-inline-edit-extension@4.0.1
 - @patternfly/react-styled-system@4.0.1
 - @patternfly/react-styles@4.0.1
 - @patternfly/react-table@4.0.1
 - @patternfly/react-tokens@4.0.1
 - @patternfly/react-topology@4.0.1
 - @patternfly/react-virtualized-extension@4.0.1

* make sure all packages publish to prerelease channel

* chore(release): releasing packages [ci skip]

 - @patternfly/react-core@4.0.2
 - @patternfly/react-docs@4.20.26
 - @patternfly/react-icons@3.15.6
 - @patternfly/react-inline-edit-extension@4.0.2
 - @patternfly/react-table@4.0.2
 - @patternfly/react-topology@4.0.2
 - @patternfly/react-virtualized-extension@4.0.2

* add newline (#3868)

* bump core

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.2
 - @patternfly/react-charts@5.3.9
 - @patternfly/react-core@4.0.3
 - @patternfly/react-docs@4.20.27
 - @patternfly/react-icons@3.15.7
 - @patternfly/react-inline-edit-extension@4.0.3
 - @patternfly/react-styled-system@4.0.2
 - @patternfly/react-styles@4.0.2
 - @patternfly/react-table@4.0.3
 - @patternfly/react-tokens@4.0.2
 - @patternfly/react-topology@4.0.3
 - @patternfly/react-virtualized-extension@4.0.3

* chore(v4): bump other packages to versions that don't conflict with master

* chore(release): releasing packages [ci skip]

 - @patternfly/react-charts@6.0.1
 - @patternfly/react-codemods@2.0.1
 - @patternfly/react-docs@5.0.1
 - @patternfly/react-icons@4.0.1
 - @patternfly/react-integration@4.0.1

* build(v4): fix build on v4 (#3915)

* fix hoist-non-react-statics types

* also verify @patternfly package versions

* run verify script with --fix

* fix hoist-non-react-statics declaration

* fix linting errors

* fix drawer panel style

* update snapshots

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.3
 - @patternfly/react-charts@6.0.2
 - @patternfly/react-codemods@2.0.2
 - @patternfly/react-core@4.0.4
 - @patternfly/react-docs@5.0.2
 - @patternfly/react-icons@4.0.2
 - @patternfly/react-inline-edit-extension@4.0.4
 - demo-app-ts@3.25.10
 - @patternfly/react-integration@4.0.2
 - @patternfly/react-styled-system@4.0.3
 - @patternfly/react-table@4.0.4
 - @patternfly/react-topology@4.0.4
 - @patternfly/react-virtualized-extension@4.0.4

* chore(v4): merge master (#3921)

* fix(ouia): don't omit ouiaContext (#3872)

* feat(Modal): add description property (#3821)

* feat(Modal): add description property, update id location when desc exists

* fix(Modal): lint error

* feat(Modal): add description to Modal

* feat(Modal): add description example to integration and cypress

* feat(Modal): update docs

* feat(DataList): add compact data list (#3807)

* feat(DataList): add compact flag

* feat(DataList): update tests, snapshots

* feat(DataList): add compact demo to integration

* feat(DataList): move integration demo back to integration

* docs(DataList): update aria label on example

* bump react-docs version (#3879)

* fix(wizard): use patternfly-styles to set the no padding modifier (#3871)

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

* chore(react): bump to current tagged version in git (#3881)

* bump to current tagged version

* bump other problematic packages

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.22
 - @patternfly/react-charts@5.3.10
 - @patternfly/react-core@3.143.0
 - @patternfly/react-docs@4.20.28
 - @patternfly/react-icons@3.15.8
 - @patternfly/react-inline-edit-extension@2.17.22
 - demo-app-ts@3.26.0
 - @patternfly/react-integration@3.26.0
 - @patternfly/react-table@2.28.3
 - @patternfly/react-topology@2.14.22
 - @patternfly/react-virtualized-extension@1.4.23

* feat(ChipGroup): Added a tooltip to the Chipgroup label (#3826)

* feat(ChipGroup): Added a tooltip to the Chipgroup label

#3490

* fix linting errors

* add tabindex

* fix tabindex

* remove redundant code

Co-authored-by: Titani <tlabaj@redaht.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.23
 - @patternfly/react-core@3.144.0
 - @patternfly/react-docs@4.20.29
 - @patternfly/react-inline-edit-extension@2.17.23
 - demo-app-ts@3.27.0
 - @patternfly/react-integration@3.27.0
 - @patternfly/react-table@2.28.4
 - @patternfly/react-topology@2.14.23
 - @patternfly/react-virtualized-extension@1.4.24

* chore(react-core): remove exenv and lodash (#3882)

* chore(react-core): remove exenv and lodash

* remove accidental focus-trap change

* fix lint

* fix lint

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.24
 - @patternfly/react-codemods@1.1.5
 - @patternfly/react-core@3.144.1
 - @patternfly/react-docs@4.20.30
 - @patternfly/react-icons@3.15.9
 - @patternfly/react-inline-edit-extension@2.17.24
 - demo-app-ts@3.27.1
 - @patternfly/react-table@2.28.5
 - @patternfly/react-topology@2.14.24
 - @patternfly/react-virtualized-extension@1.4.25

* feat(Select): add inline filtering to checkbox select (#3843)

* feat(Select): add inline filtering

* feat(Select): add unit test

* feat(Select): add filtering select demo to integration

* feat(Select): add clear button, fix lint, update wider snapshots

* fix(integration): fix lint

* fix(docs): add missing import

* feat(Select): update integration tests with clear button changes

* feat(Select): move integration demos back to integration

* feat(Select): remove typeahead restriction on clear button

* docs(Select): update docs example

* PF4: Drawer updates for Master/Detail Support (#3884)

* feat(Drawer): Updated Drawer to support Master/Detail

#3609

* rebase

* update file that was not saved

* Update snapshots

* fix linting errors

* fix linting errors

* fix spacing issue

* updates from review comments

* updates from review comments

Co-authored-by: Titani <tlabaj@redaht.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.25
 - @patternfly/react-charts@5.3.11
 - @patternfly/react-core@3.145.0
 - @patternfly/react-docs@4.20.31
 - @patternfly/react-icons@3.15.10
 - @patternfly/react-inline-edit-extension@2.17.25
 - demo-app-ts@3.28.0
 - @patternfly/react-integration@3.28.0
 - @patternfly/react-styled-system@3.8.9
 - @patternfly/react-styles@3.7.7
 - @patternfly/react-table@2.28.6
 - @patternfly/react-tokens@2.8.7
 - @patternfly/react-topology@2.14.25
 - @patternfly/react-virtualized-extension@1.4.26

* fix (datatoolbar):  Added support for key with categoryName. (#3880)

* Issue3552 - added support for key with categoryName.

* Update to fix memory leak with datatoolbar filter.

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.26
 - @patternfly/react-core@3.145.1
 - @patternfly/react-docs@4.20.32
 - @patternfly/react-inline-edit-extension@2.17.26
 - demo-app-ts@3.28.1
 - @patternfly/react-table@2.28.7
 - @patternfly/react-topology@2.14.26
 - @patternfly/react-virtualized-extension@1.4.27

* feat(FileUpload) Add new beta File Upload component (#3865)

* feat(FileUpload) Add new beta File Upload component

* Bump patternfly versions to 2.68.3

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.27
 - @patternfly/react-charts@5.3.12
 - @patternfly/react-core@3.145.2
 - @patternfly/react-docs@4.20.33
 - @patternfly/react-icons@3.15.11
 - @patternfly/react-inline-edit-extension@2.17.27
 - demo-app-ts@3.28.2
 - @patternfly/react-styled-system@3.8.10
 - @patternfly/react-styles@3.7.8
 - @patternfly/react-table@2.28.8
 - @patternfly/react-tokens@2.8.8
 - @patternfly/react-topology@2.14.27
 - @patternfly/react-virtualized-extension@1.4.28

* destructure bubbleEvent from props to avoid it passing to button el (#3894)

* destructure bubbleEvent from props to avoid it passing to button el

* updated snapshots

* updated Table snapshot

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.28
 - @patternfly/react-core@3.145.3
 - @patternfly/react-docs@4.20.34
 - @patternfly/react-inline-edit-extension@2.17.28
 - demo-app-ts@3.28.3
 - @patternfly/react-table@2.28.9
 - @patternfly/react-topology@2.14.28
 - @patternfly/react-virtualized-extension@1.4.29

* feat(Modal): move description to separate component (#3897)

* feat(Modal): move description to separate component

* feat(Modal): fix property descriptions

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.29
 - @patternfly/react-core@3.146.0
 - @patternfly/react-docs@4.20.35
 - @patternfly/react-inline-edit-extension@2.17.29
 - demo-app-ts@3.28.4
 - @patternfly/react-table@2.28.10
 - @patternfly/react-topology@2.14.29
 - @patternfly/react-virtualized-extension@1.4.30

* chore(Realease Notes): Updated release notes for 2020.03 release (#3892)

* chore(Realease Notes): Updated release notes for 2020.03 release

#3891

* updates from comments

* update versions

* update based on comments

* update based on comments

* Update release notes

Fixed react-topology NPM link and Modal bullet points link text

Co-authored-by: Titani <tlabaj@redaht.com>
Co-authored-by: Evan <evan.wilkinson@redhat.com>

* fix(nothing): bumping to release 2020.03 release notes (#3908)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.30
 - @patternfly/react-core@3.146.1
 - @patternfly/react-docs@4.20.36
 - @patternfly/react-inline-edit-extension@2.17.30
 - demo-app-ts@3.28.5
 - @patternfly/react-table@2.28.11
 - @patternfly/react-topology@2.14.30
 - @patternfly/react-virtualized-extension@1.4.31

* blank update to force deploy (#3910)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.31
 - @patternfly/react-core@3.146.2
 - @patternfly/react-docs@4.20.37
 - @patternfly/react-inline-edit-extension@2.17.31
 - demo-app-ts@3.28.6
 - @patternfly/react-integration@3.28.1
 - @patternfly/react-table@2.28.12
 - @patternfly/react-topology@2.14.31
 - @patternfly/react-virtualized-extension@1.4.32

* fix(dropdown): clean console errors in Dropdown.test.tsx (#3861)

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

* fix(aboutmodal): set a customize aria-label to the close button (#3877)

* fix(aboutmodal): set a customize aria-label to the close button

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

* Quick sentence-case fix

Co-authored-by: Eugenia <32821331+jenny-s51@users.noreply.github.com>

* chore(repo): remove unused packages (#3916)

* remove unused packages

* fix hoist-non-react-statics type

* remove react-styled-system from react-docs

* fix lint

* don't deploy PRs from v4 branch

* enable chrome web security for failing cypress test

* fix external button link

* fix lint

Co-authored-by: Evan <evan.wilkinson@gmail.com>
Co-authored-by: Dan Labrecque <dlabrecq@redhat.com>
Co-authored-by: Titani Labaj <39532947+tlabaj@users.noreply.github.com>
Co-authored-by: patternfly-build <patternfly-build@redhat.com>
Co-authored-by: Titani <tlabaj@redaht.com>
Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com>
Co-authored-by: Donald Labaj <donald.labaj@gmail.com>
Co-authored-by: Mike Turley <mike.turley@alum.cs.umass.edu>
Co-authored-by: Evan <evan.wilkinson@redhat.com>
Co-authored-by: boaz0 <boaz.shuster.github@gmail.com>
Co-authored-by: Eugenia <32821331+jenny-s51@users.noreply.github.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.4
 - @patternfly/react-core@4.0.5
 - @patternfly/react-docs@5.0.3
 - @patternfly/react-icons@4.0.3
 - @patternfly/react-inline-edit-extension@4.0.5
 - demo-app-ts@4.0.1
 - @patternfly/react-integration@4.0.3
 - @patternfly/react-table@4.0.5
 - @patternfly/react-topology@4.0.5
 - @patternfly/react-virtualized-extension@4.0.5

* perf(react-styles): remove emotion, fix types (#3886)

* fix(ouia): don't omit ouiaContext (#3872)

* feat(Modal): add description property (#3821)

* feat(Modal): add description property, update id location when desc exists

* fix(Modal): lint error

* feat(Modal): add description to Modal

* feat(Modal): add description example to integration and cypress

* feat(Modal): update docs

* feat(DataList): add compact data list (#3807)

* feat(DataList): add compact flag

* feat(DataList): update tests, snapshots

* feat(DataList): add compact demo to integration

* feat(DataList): move integration demo back to integration

* docs(DataList): update aria label on example

* bump react-docs version (#3879)

* fix(wizard): use patternfly-styles to set the no padding modifier (#3871)

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

* chore(react): bump to current tagged version in git (#3881)

* bump to current tagged version

* bump other problematic packages

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.22
 - @patternfly/react-charts@5.3.10
 - @patternfly/react-core@3.143.0
 - @patternfly/react-docs@4.20.28
 - @patternfly/react-icons@3.15.8
 - @patternfly/react-inline-edit-extension@2.17.22
 - demo-app-ts@3.26.0
 - @patternfly/react-integration@3.26.0
 - @patternfly/react-table@2.28.3
 - @patternfly/react-topology@2.14.22
 - @patternfly/react-virtualized-extension@1.4.23

* remove emotion, fix types

* fix some tests

* fix tests

* feat(ChipGroup): Added a tooltip to the Chipgroup label (#3826)

* feat(ChipGroup): Added a tooltip to the Chipgroup label

#3490

* fix linting errors

* add tabindex

* fix tabindex

* remove redundant code

Co-authored-by: Titani <tlabaj@redaht.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.23
 - @patternfly/react-core@3.144.0
 - @patternfly/react-docs@4.20.29
 - @patternfly/react-inline-edit-extension@2.17.23
 - demo-app-ts@3.27.0
 - @patternfly/react-integration@3.27.0
 - @patternfly/react-table@2.28.4
 - @patternfly/react-topology@2.14.23
 - @patternfly/react-virtualized-extension@1.4.24

* add hoist-non-react-statics types

* fix v4 package versions

* chore(react-core): remove exenv and lodash (#3882)

* chore(react-core): remove exenv and lodash

* remove accidental focus-trap change

* fix lint

* fix lint

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.24
 - @patternfly/react-codemods@1.1.5
 - @patternfly/react-core@3.144.1
 - @patternfly/react-docs@4.20.30
 - @patternfly/react-icons@3.15.9
 - @patternfly/react-inline-edit-extension@2.17.24
 - demo-app-ts@3.27.1
 - @patternfly/react-table@2.28.5
 - @patternfly/react-topology@2.14.24
 - @patternfly/react-virtualized-extension@1.4.25

* ts fixes

* fix lint

* fix backgroundImage on chrome

* fix filter

* fix merge conflict

* fix lint+snaps

* fix invalid data toolbar classes

* linting

* remove console logs

* add aria-label to wizard toggle

* update snapshots

* update snapshots

* address joachim's feedback

* remove accidental auto-import

* update snapshots

Co-authored-by: Evan <evan.wilkinson@gmail.com>
Co-authored-by: Dan Labrecque <dlabrecq@redhat.com>
Co-authored-by: Titani Labaj <39532947+tlabaj@users.noreply.github.com>
Co-authored-by: patternfly-build <patternfly-build@redhat.com>
Co-authored-by: Titani <tlabaj@redaht.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.5
 - @patternfly/react-charts@6.0.3
 - @patternfly/react-core@4.0.6
 - @patternfly/react-docs@5.0.4
 - @patternfly/react-inline-edit-extension@4.0.6
 - demo-app-ts@4.0.2
 - @patternfly/react-integration@4.0.4
 - @patternfly/react-styles@4.0.3
 - @patternfly/react-table@4.0.6
 - @patternfly/react-topology@4.0.6
 - @patternfly/react-virtualized-extension@4.0.6

* perf(ouia): make ouia functional, add namespace (#3927)

* helper implementation

* update ouia components

* rename data-ouia-id to data-ouia-component-id

* fix lint

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.6
 - @patternfly/react-charts@6.0.4
 - @patternfly/react-core@4.0.7
 - @patternfly/react-docs@5.0.5
 - @patternfly/react-inline-edit-extension@4.0.7
 - demo-app-ts@4.0.3
 - @patternfly/react-integration@4.0.5
 - @patternfly/react-styles@4.0.4
 - @patternfly/react-table@4.0.7
 - @patternfly/react-topology@4.0.7
 - @patternfly/react-virtualized-extension@4.0.7

* Empty state width (#3933)

* refactor(Empty State): Change the default width to full instead of large

#3221

* add dchanges for issue #3873

* fix demo app

Co-authored-by: Titani <tlabaj@redaht.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.7
 - @patternfly/react-core@4.0.8
 - @patternfly/react-docs@5.0.6
 - @patternfly/react-inline-edit-extension@4.0.8
 - demo-app-ts@4.0.4
 - @patternfly/react-integration@4.0.6
 - @patternfly/react-table@4.0.8
 - @patternfly/react-topology@4.0.8
 - @patternfly/react-virtualized-extension@4.0.8

* fix(react-integration): no implicit any (#3928)

* fixed implicit any errors through DataToolbarDemo

* resolved errors through FormSelectDemo

* resolved all noImplicitAny within react-integration

* reverted null value

* reverted undefined values

* updated SelectDemo arrays

* strict function types on contextselector and datatoolbar

* Revert "strict function types on contextselector and datatoolbar"

This reverts commit 5ff0abf735ba7b4c65a2277d6c16d2821de894d5.

* removed any where possible

* PR feedback fixes - added back in untyped events

* PR feedback - removed editing prevState in DataToolbar

* updated DataToolbar core example

* remove type from core example

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.8
 - @patternfly/react-core@4.0.9
 - @patternfly/react-docs@5.0.7
 - @patternfly/react-inline-edit-extension@4.0.9
 - demo-app-ts@4.0.5
 - @patternfly/react-integration@4.0.7
 - @patternfly/react-table@4.0.9
 - @patternfly/react-topology@4.0.9
 - @patternfly/react-virtualized-extension@4.0.9

* refactor(ApplicationLauncher): Removed the deprecated prop dropdownItems (#3929)

* refactor(ApplicationLauncher): Removed the deprecated prop dropdownItems

#2582

* rebase

Co-authored-by: Titani <tlabaj@redaht.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.9
 - @patternfly/react-core@4.0.10
 - @patternfly/react-docs@5.0.8
 - @patternfly/react-inline-edit-extension@4.0.10
 - demo-app-ts@4.0.6
 - @patternfly/react-integration@4.0.8
 - @patternfly/react-table@4.0.10
 - @patternfly/react-topology@4.0.10
 - @patternfly/react-virtualized-extension@4.0.10

* fix(table): update types in table (#3296)

update/align onSelect event type from React.MouseEvent and React.ChangeEvent<HTMLInputElement> to React.FormEvent<HTMLInputElement>
clear todo and tslint error in selectable transform
types for ICustomCell and ISelectTransform
clear noImplicitAny errors for Table

* chore(release): releasing packages [ci skip]

 - @patternfly/react-docs@5.0.9
 - @patternfly/react-inline-edit-extension@4.0.11
 - demo-app-ts@4.0.7
 - @patternfly/react-integration@4.0.9
 - @patternfly/react-table@4.0.11

* Aria property name updates (#3924)

* fix(aria-props): align aria related property names #1529

* [cleanup] sentence case for aria-prop docs

* feat(Alert): change default alert variant to default (#3903)

* feat(Alert): change default alert variant to default

* feat(Alert): rebase conflicts, update demo app

* feat(Alert): update snapshots

* feat(Page): make mainContainerId required (#3904)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.10
 - @patternfly/react-core@4.1.0
 - @patternfly/react-docs@5.0.10
 - @patternfly/react-inline-edit-extension@4.0.12
 - demo-app-ts@4.1.0
 - @patternfly/react-integration@4.1.0
 - @patternfly/react-table@4.0.12
 - @patternfly/react-topology@4.0.11
 - @patternfly/react-virtualized-extension@4.0.11

* feat(Charts): Bump Victory packages (3973) (#3974)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-charts@6.1.0
 - @patternfly/react-docs@5.0.11

* reordered examples, renamed simple to basic (#3970)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.11
 - @patternfly/react-core@4.1.1
 - @patternfly/react-docs@5.0.12
 - @patternfly/react-inline-edit-extension@4.0.13
 - demo-app-ts@4.1.1
 - @patternfly/react-table@4.0.13
 - @patternfly/react-topology@4.0.12
 - @patternfly/react-virtualized-extension@4.0.12

* Breaking modal variant (#3920)

* feat(Modal): collapse isSmall and isLarge into variant

* feat(Modal): update snapshots

* feat(Modal): update demo app

* feat(Modal): update snapshots

* feat(Modal): rename medium to default for modal size variant

* feat(Select): change isExpanded to isOpen, split selections prop, rem… (#3945)

* feat(Select): change isExpanded to isOpen, split selections prop, remove old CheckboxSelect

also small reorganizations to clean up code

* feat(Misc): update snapshots after rebase

* feat(various): update select examples & demo app

* feat(misc): update snapshots after rebase

* feat(Select): fix typings of display function

* feat(Select): update custom filter example to use internal filtering logic

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.12
 - @patternfly/react-core@4.2.0
 - @patternfly/react-docs@5.0.13
 - @patternfly/react-inline-edit-extension@4.0.14
 - demo-app-ts@4.2.0
 - @patternfly/react-integration@4.2.0
 - @patternfly/react-table@4.0.14
 - @patternfly/react-topology@4.0.13
 - @patternfly/react-virtualized-extension@4.0.13

* fix(icons): fix types, upgrade typescript (#3978)

* half refactor

* cleanup

* fix lint

* upgrade typescript to fix build

* fix tests

* fix lint

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.13
 - @patternfly/react-charts@6.1.1
 - @patternfly/react-core@4.2.1
 - @patternfly/react-docs@5.0.14
 - @patternfly/react-icons@4.0.4
 - @patternfly/react-inline-edit-extension@4.0.15
 - demo-app-ts@4.2.1
 - @patternfly/react-integration@4.2.1
 - @patternfly/react-styles@4.0.5
 - @patternfly/react-table@4.0.15
 - @patternfly/react-topology@4.0.14
 - @patternfly/react-virtualized-extension@4.0.14

* Make tooltip examples keyboard accessible (#3962)

* FormGroup, TextInput, TextArea, FormSelect (#3975)

* refactor(FormGroup, TextInput, TextArea, FormSelect): removed the deprcated isValid prop

#3906 #3870

* rebase

* fix linting

* fix FormSelect docs

* update FormSelect docs

* update snapshots

* update tests

* update failing snap

Co-authored-by: Titani <tlabaj@redaht.com>

* updates react-icons readme (#3958)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.14
 - @patternfly/react-core@4.2.2
 - @patternfly/react-docs@5.0.15
 - @patternfly/react-icons@4.0.5
 - @patternfly/react-inline-edit-extension@4.0.16
 - demo-app-ts@4.2.2
 - @patternfly/react-integration@4.2.2
 - @patternfly/react-table@4.0.16
 - @patternfly/react-topology@4.0.15
 - @patternfly/react-virtualized-extension@4.0.15

* fix(title): remove problematic default headingLevel (#3922)

* fix(title): remove default headingLevel and TitleSize, api updates

* [issue-1439] fix missed api update, ensure heading levels increment by one

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.15
 - @patternfly/react-core@4.2.3
 - @patternfly/react-docs@5.0.16
 - @patternfly/react-inline-edit-extension@4.0.17
 - demo-app-ts@4.2.3
 - @patternfly/react-integration@4.2.3
 - @patternfly/react-table@4.0.17
 - @patternfly/react-topology@4.0.16
 - @patternfly/react-virtualized-extension@4.0.16

* fix(table): expandable example title (#3985)

Adds a missing p to the title

* chore(release): releasing packages [ci skip]

 - @patternfly/react-docs@5.0.17
 - @patternfly/react-inline-edit-extension@4.0.18
 - @patternfly/react-table@4.0.18

* chore(release): merge master for 2020.04 (#3991)

* fix(ouia): don't omit ouiaContext (#3872)

* feat(Modal): add description property (#3821)

* feat(Modal): add description property, update id location when desc exists

* fix(Modal): lint error

* feat(Modal): add description to Modal

* feat(Modal): add description example to integration and cypress

* feat(Modal): update docs

* feat(DataList): add compact data list (#3807)

* feat(DataList): add compact flag

* feat(DataList): update tests, snapshots

* feat(DataList): add compact demo to integration

* feat(DataList): move integration demo back to integration

* docs(DataList): update aria label on example

* bump react-docs version (#3879)

* fix(wizard): use patternfly-styles to set the no padding modifier (#3871)

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

* chore(react): bump to current tagged version in git (#3881)

* bump to current tagged version

* bump other problematic packages

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.22
 - @patternfly/react-charts@5.3.10
 - @patternfly/react-core@3.143.0
 - @patternfly/react-docs@4.20.28
 - @patternfly/react-icons@3.15.8
 - @patternfly/react-inline-edit-extension@2.17.22
 - demo-app-ts@3.26.0
 - @patternfly/react-integration@3.26.0
 - @patternfly/react-table@2.28.3
 - @patternfly/react-topology@2.14.22
 - @patternfly/react-virtualized-extension@1.4.23

* feat(ChipGroup): Added a tooltip to the Chipgroup label (#3826)

* feat(ChipGroup): Added a tooltip to the Chipgroup label

#3490

* fix linting errors

* add tabindex

* fix tabindex

* remove redundant code

Co-authored-by: Titani <tlabaj@redaht.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.23
 - @patternfly/react-core@3.144.0
 - @patternfly/react-docs@4.20.29
 - @patternfly/react-inline-edit-extension@2.17.23
 - demo-app-ts@3.27.0
 - @patternfly/react-integration@3.27.0
 - @patternfly/react-table@2.28.4
 - @patternfly/react-topology@2.14.23
 - @patternfly/react-virtualized-extension@1.4.24

* chore(react-core): remove exenv and lodash (#3882)

* chore(react-core): remove exenv and lodash

* remove accidental focus-trap change

* fix lint

* fix lint

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.24
 - @patternfly/react-codemods@1.1.5
 - @patternfly/react-core@3.144.1
 - @patternfly/react-docs@4.20.30
 - @patternfly/react-icons@3.15.9
 - @patternfly/react-inline-edit-extension@2.17.24
 - demo-app-ts@3.27.1
 - @patternfly/react-table@2.28.5
 - @patternfly/react-topology@2.14.24
 - @patternfly/react-virtualized-extension@1.4.25

* feat(Select): add inline filtering to checkbox select (#3843)

* feat(Select): add inline filtering

* feat(Select): add unit test

* feat(Select): add filtering select demo to integration

* feat(Select): add clear button, fix lint, update wider snapshots

* fix(integration): fix lint

* fix(docs): add missing import

* feat(Select): update integration tests with clear button changes

* feat(Select): move integration demos back to integration

* feat(Select): remove typeahead restriction on clear button

* docs(Select): update docs example

* PF4: Drawer updates for Master/Detail Support (#3884)

* feat(Drawer): Updated Drawer to support Master/Detail

#3609

* rebase

* update file that was not saved

* Update snapshots

* fix linting errors

* fix linting errors

* fix spacing issue

* updates from review comments

* updates from review comments

Co-authored-by: Titani <tlabaj@redaht.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.25
 - @patternfly/react-charts@5.3.11
 - @patternfly/react-core@3.145.0
 - @patternfly/react-docs@4.20.31
 - @patternfly/react-icons@3.15.10
 - @patternfly/react-inline-edit-extension@2.17.25
 - demo-app-ts@3.28.0
 - @patternfly/react-integration@3.28.0
 - @patternfly/react-styled-system@3.8.9
 - @patternfly/react-styles@3.7.7
 - @patternfly/react-table@2.28.6
 - @patternfly/react-tokens@2.8.7
 - @patternfly/react-topology@2.14.25
 - @patternfly/react-virtualized-extension@1.4.26

* fix (datatoolbar):  Added support for key with categoryName. (#3880)

* Issue3552 - added support for key with categoryName.

* Update to fix memory leak with datatoolbar filter.

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.26
 - @patternfly/react-core@3.145.1
 - @patternfly/react-docs@4.20.32
 - @patternfly/react-inline-edit-extension@2.17.26
 - demo-app-ts@3.28.1
 - @patternfly/react-table@2.28.7
 - @patternfly/react-topology@2.14.26
 - @patternfly/react-virtualized-extension@1.4.27

* feat(FileUpload) Add new beta File Upload component (#3865)

* feat(FileUpload) Add new beta File Upload component

* Bump patternfly versions to 2.68.3

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.27
 - @patternfly/react-charts@5.3.12
 - @patternfly/react-core@3.145.2
 - @patternfly/react-docs@4.20.33
 - @patternfly/react-icons@3.15.11
 - @patternfly/react-inline-edit-extension@2.17.27
 - demo-app-ts@3.28.2
 - @patternfly/react-styled-system@3.8.10
 - @patternfly/react-styles@3.7.8
 - @patternfly/react-table@2.28.8
 - @patternfly/react-tokens@2.8.8
 - @patternfly/react-topology@2.14.27
 - @patternfly/react-virtualized-extension@1.4.28

* destructure bubbleEvent from props to avoid it passing to button el (#3894)

* destructure bubbleEvent from props to avoid it passing to button el

* updated snapshots

* updated Table snapshot

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.28
 - @patternfly/react-core@3.145.3
 - @patternfly/react-docs@4.20.34
 - @patternfly/react-inline-edit-extension@2.17.28
 - demo-app-ts@3.28.3
 - @patternfly/react-table@2.28.9
 - @patternfly/react-topology@2.14.28
 - @patternfly/react-virtualized-extension@1.4.29

* feat(Modal): move description to separate component (#3897)

* feat(Modal): move description to separate component

* feat(Modal): fix property descriptions

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.29
 - @patternfly/react-core@3.146.0
 - @patternfly/react-docs@4.20.35
 - @patternfly/react-inline-edit-extension@2.17.29
 - demo-app-ts@3.28.4
 - @patternfly/react-table@2.28.10
 - @patternfly/react-topology@2.14.29
 - @patternfly/react-virtualized-extension@1.4.30

* chore(Realease Notes): Updated release notes for 2020.03 release (#3892)

* chore(Realease Notes): Updated release notes for 2020.03 release

#3891

* updates from comments

* update versions

* update based on comments

* update based on comments

* Update release notes

Fixed react-topology NPM link and Modal bullet points link text

Co-authored-by: Titani <tlabaj@redaht.com>
Co-authored-by: Evan <evan.wilkinson@redhat.com>

* fix(nothing): bumping to release 2020.03 release notes (#3908)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.30
 - @patternfly/react-core@3.146.1
 - @patternfly/react-docs@4.20.36
 - @patternfly/react-inline-edit-extension@2.17.30
 - demo-app-ts@3.28.5
 - @patternfly/react-table@2.28.11
 - @patternfly/react-topology@2.14.30
 - @patternfly/react-virtualized-extension@1.4.31

* blank update to force deploy (#3910)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.31
 - @patternfly/react-core@3.146.2
 - @patternfly/react-docs@4.20.37
 - @patternfly/react-inline-edit-extension@2.17.31
 - demo-app-ts@3.28.6
 - @patternfly/react-integration@3.28.1
 - @patternfly/react-table@2.28.12
 - @patternfly/react-topology@2.14.31
 - @patternfly/react-virtualized-extension@1.4.32

* fix(dropdown): clean console errors in Dropdown.test.tsx (#3861)

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

* fix(aboutmodal): set a customize aria-label to the close button (#3877)

* fix(aboutmodal): set a customize aria-label to the close button

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

* Quick sentence-case fix

Co-authored-by: Eugenia <32821331+jenny-s51@users.noreply.github.com>

* chore(repo): remove unused packages (#3916)

* remove unused packages

* fix hoist-non-react-statics type

* remove react-styled-system from react-docs

* fix lint

* feat(EmptyState): Added support for extra-large empty state (#3844)

* feat(EmptyState): Added support for extra-large empty state

Added new prop and updated examples

Fixes 3540

* Change prop name

* Adjust title size

* fix(core,table): forward ref types (#3919)

* fix(react,table): forward ref types

* fix demo app build

* update snapshots

* fix lint

* fix(dropdown): remove duplicate prop (#3923)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.32
 - @patternfly/react-charts@5.3.13
 - @patternfly/react-core@3.147.0
 - @patternfly/react-docs@4.20.38
 - @patternfly/react-icons@3.15.12
 - @patternfly/react-inline-edit-extension@2.17.32
 - demo-app-ts@3.28.7
 - @patternfly/react-integration@3.28.2
 - @patternfly/react-styles@3.7.9
 - @patternfly/react-table@2.28.13
 - @patternfly/react-topology@2.14.32
 - @patternfly/react-virtualized-extension@1.4.33

* fix(select): fix group select options in single variant (#3838)

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.33
 - @patternfly/react-core@3.147.1
 - @patternfly/react-docs@4.20.39
 - @patternfly/react-inline-edit-extension@2.17.33
 - demo-app-ts@3.28.8
 - @patternfly/react-table@2.28.14
 - @patternfly/react-topology@2.14.33
 - @patternfly/react-virtualized-extension@1.4.34

* feat(Select): add logic for disabled default options for typeahead (#3895)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.34
 - @patternfly/react-core@3.148.0
 - @patternfly/react-docs@4.20.40
 - @patternfly/react-inline-edit-extension@2.17.34
 - demo-app-ts@3.28.9
 - @patternfly/react-table@2.28.15
 - @patternfly/react-topology@2.14.34
 - @patternfly/react-virtualized-extension@1.4.35

* react-tokens: Variables by file (#3896)

* change

* react-tokens by file

* readme

* fix linting

* address comments

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.35
 - @patternfly/react-charts@5.3.14
 - @patternfly/react-core@3.148.1
 - @patternfly/react-docs@4.20.41
 - @patternfly/react-inline-edit-extension@2.17.35
 - demo-app-ts@3.28.10
 - @patternfly/react-table@2.28.16
 - @patternfly/react-tokens@2.8.9
 - @patternfly/react-topology@2.14.35
 - @patternfly/react-virtualized-extension@1.4.36

* fix(alert): use context to set label (#3771)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.36
 - @patternfly/react-core@3.148.2
 - @patternfly/react-docs@4.20.42
 - @patternfly/react-inline-edit-extension@2.17.36
 - demo-app-ts@3.28.11
 - @patternfly/react-table@2.28.17
 - @patternfly/react-topology@2.14.36
 - @patternfly/react-virtualized-extension@1.4.37

* chore(ts): fix tippy types, remove copyTS (#3940)

* chore(ts): fix tippy types, remove copyTS

* fix lint

* chore(react-docs): release docs to NPM for patternfly-org (#3941)

* chore(docs): publish training.md and RELEASE-NOTES.md

* use hard link

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.37
 - @patternfly/react-charts@5.3.15
 - @patternfly/react-core@3.148.3
 - @patternfly/react-docs@4.20.43
 - @patternfly/react-inline-edit-extension@2.17.37
 - demo-app-ts@3.28.12
 - @patternfly/react-table@2.28.18
 - @patternfly/react-topology@2.14.37
 - @patternfly/react-virtualized-extension@1.4.38

* feat(card view): Adds Card View to demos (#3441)

* WIP: demo for card view

* adding icons and resolving error with path

* adding toolbar and dropdown functionality

* adding onFocus and renaming functions

* cleaning up -- reordering functions

* fix indentation

* fixes interaction bugs, cleans up method/variable names

* removing log statement

* adding demo file

* cleaning up

* cleaning up a bit, working on delete function

* CardView: fixed deleteItem function

* cleaning up code, removing onFocus

* removing .tsx demo file

* addressing PR feedback

* adding WIP bulk-select

* add WIP filter dropdown

* adds filtering functions, WIP

* filter working, moving onto bulk select

* adding chips, bulk-select WIP

* WIP bulk-select

* adding logic for selecting all cards

* commenting out handleSelectClick for now

* adds and calls updateSelected

* fix dropdown toggle

* selectAll is working, WIP

* reordering functions, fixing undefined errors

* select all/select none works!

* can interact with list, WIP

* can select individually!

* adding checked prop, WIP

* bulk select is working! pagination/paginated bulk-select WIP

* formatting

* selectpage is working

* CardView ready for review

* fix md linting error

* fixing interaction bugs

* resolves bug with deleteItem

* cleaning up

* removing div used for testing

* changing default perPage values, fixes minor bug in page select

* removing unnecessary div, set default perPage back to 10

* removing lower pagination

* removing comment

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.38
 - @patternfly/react-core@3.149.0
 - @patternfly/react-docs@4.20.44
 - @patternfly/react-inline-edit-extension@2.17.38
 - demo-app-ts@3.28.13
 - @patternfly/react-table@2.28.19
 - @patternfly/react-topology@2.14.38
 - @patternfly/react-virtualized-extension@1.4.39

* make proper soft symlink that is still packaged by NPM (#3950)

* fix(card): add wrapper to image to resize it properly (#3642)

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.39
 - @patternfly/react-core@3.149.1
 - @patternfly/react-docs@4.20.45
 - @patternfly/react-inline-edit-extension@2.17.39
 - demo-app-ts@3.28.14
 - @patternfly/react-table@2.28.20
 - @patternfly/react-topology@2.14.39
 - @patternfly/react-virtualized-extension@1.4.40

* chore(repo): bump core to 2.70.1 (#3964)

* chore(repo): bump core to 2.70.1

* add img alt for cardview demo

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.40
 - @patternfly/react-charts@5.3.16
 - @patternfly/react-core@3.149.2
 - @patternfly/react-docs@4.20.46
 - @patternfly/react-icons@3.15.13
 - @patternfly/react-inline-edit-extension@2.17.40
 - demo-app-ts@3.28.15
 - @patternfly/react-styles@3.7.10
 - @patternfly/react-table@2.28.21
 - @patternfly/react-tokens@2.8.10
 - @patternfly/react-topology@2.14.40
 - @patternfly/react-virtualized-extension@1.4.41

* chore(prop-types): remove a few usages (#3968)

* chore(deps): in-house focusTrap (#3967)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.41
 - @patternfly/react-core@3.149.3
 - @patternfly/react-docs@4.20.47
 - @patternfly/react-inline-edit-extension@2.17.41
 - demo-app-ts@3.28.16
 - @patternfly/react-integration@3.28.3
 - @patternfly/react-table@2.28.22
 - @patternfly/react-topology@2.14.41
 - @patternfly/react-virtualized-extension@1.4.42

* feat(rollup): create unified react-core dist (#3971)

* add rollup config

* fix circular deps

* fix rollup config

* add documentation

* fix lint

* export contexts to consumers

* fix a11y in cardview demo

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.42
 - @patternfly/react-core@3.150.0
 - @patternfly/react-docs@4.21.0
 - @patternfly/react-inline-edit-extension@2.17.42
 - demo-app-ts@3.28.17
 - @patternfly/react-table@2.28.23
 - @patternfly/react-topology@2.14.42
 - @patternfly/react-virtualized-extension@1.4.43

* docs(Table column management demo): Added demo (#3942)

* docs(Table column management demo): Added demo to illustrate how you can remove/add columns

Users can click into the modal to edit which columns are displayed.

Fixes #3898

* fix webpack error

* Update checkbox names, text

* docs(Table column management demo): Added demo to illustrate how you can remove/add columns

Users can click into the modal to edit which columns are displayed.

Fixes #3898

* fix webpack error

* Update checkbox names, text

Co-authored-by: redallen <zallen@redhat.com>

* feat(select): Allow count badge to be hidden in checkbox select (#3976)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.43
 - @patternfly/react-core@3.151.0
 - @patternfly/react-docs@4.21.1
 - @patternfly/react-inline-edit-extension@2.17.43
 - demo-app-ts@3.29.0
 - @patternfly/react-integration@3.29.0
 - @patternfly/react-table@2.28.24
 - @patternfly/react-topology@2.14.43
 - @patternfly/react-virtualized-extension@1.4.44

* feat(Dropdown): Add new prop so Links are treated better (#3889)

* feat(Dropdown): Add new prop so Links are treated better

When prop is used, class is applied to child so that the link is full-width and even clicking on the padding gets you where you need to go. Link color also remains black.

Fixes #3641

* Fix wrapper, remove examples

* Reworked with new prop; adjusted css concatenation tool

* modification to allow react children

* examples

Co-authored-by: Joachim Schuler <jschuler@redhat.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.44
 - @patternfly/react-core@3.152.0
 - @patternfly/react-docs@4.21.2
 - @patternfly/react-inline-edit-extension@2.17.44
 - demo-app-ts@3.29.1
 - @patternfly/react-table@2.28.25
 - @patternfly/react-topology@2.14.44
 - @patternfly/react-virtualized-extension@1.4.45

* fix(docs): fix path to react-core UMD file (#3982)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-docs@4.21.3

* feat(Drawer): added width props, updated demo & integration test (#3979)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.45
 - @patternfly/react-core@3.153.0
 - @patternfly/react-docs@4.21.4
 - @patternfly/react-inline-edit-extension@2.17.45
 - demo-app-ts@3.30.0
 - @patternfly/react-integration@3.30.0
 - @patternfly/react-table@2.28.26
 - @patternfly/react-topology@2.14.45
 - @patternfly/react-virtualized-extension@1.4.46

* chore(packages): bump @patternfly/patternfly to 2.71.0 (#3989)

* chore(packages): bump @patternfly/patternfly to 2.71.0

* update to 2.71.1

* update release notes

* add closing )

* fix lint

* fix empty state demo

Co-authored-by: Evan <evan.wilkinson@gmail.com>
Co-authored-by: Dan Labrecque <dlabrecq@redhat.com>
Co-authored-by: Titani Labaj <39532947+tlabaj@users.noreply.github.com>
Co-authored-by: patternfly-build <patternfly-build@redhat.com>
Co-authored-by: Titani <tlabaj@redaht.com>
Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com>
Co-authored-by: Donald Labaj <donald.labaj@gmail.com>
Co-authored-by: Mike Turley <mike.turley@alum.cs.umass.edu>
Co-authored-by: Evan <evan.wilkinson@redhat.com>
Co-authored-by: boaz0 <boaz.shuster.github@gmail.com>
Co-authored-by: Eugenia <32821331+jenny-s51@users.noreply.github.com>
Co-authored-by: Rebecca Alpert <ralpert@redhat.com>
Co-authored-by: Joachim <jschuler@redhat.com>
Co-authored-by: Michael Spaxman <5942899+seanforyou23@users.noreply.github.com>
Co-authored-by: Jeff Phillips <jephilli@redhat.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.16
 - @patternfly/react-charts@6.1.2
 - @patternfly/react-core@4.2.4
 - @patternfly/react-docs@5.0.18
 - @patternfly/react-inline-edit-extension@4.0.19
 - demo-app-ts@4.2.4
 - @patternfly/react-integration@4.2.4
 - @patternfly/react-table@4.0.19
 - @patternfly/react-tokens@4.0.3
 - @patternfly/react-topology@4.0.17
 - @patternfly/react-virtualized-extension@4.0.17

* fix(modal): default action alignment to left (#4017)

* fix(modal): default action alignment to left

* [issue-3672] cleanup doc

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.17
 - @patternfly/react-core@4.2.5
 - @patternfly/react-docs@5.0.19
 - @patternfly/react-inline-edit-extension@4.0.20
 - demo-app-ts@4.2.5
 - @patternfly/react-integration@4.2.5
 - @patternfly/react-table@4.0.20
 - @patternfly/react-topology@4.0.18
 - @patternfly/react-virtualized-extension@4.0.18

* Merge master and bump @patternfly/patternfly to 4.6.0 (#4022)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.18
 - @patternfly/react-charts@6.1.3
 - @patternfly/react-core@4.2.6
 - @patternfly/react-docs@5.0.20
 - @patternfly/react-icons@4.0.6
 - @patternfly/react-inline-edit-extension@4.0.21
 - demo-app-ts@4.2.6
 - @patternfly/react-integration@4.2.6
 - @patternfly/react-styles@4.0.6
 - @patternfly/react-table@4.0.21
 - @patternfly/react-tokens@4.0.4
 - @patternfly/react-topology@4.0.19
 - @patternfly/react-virtualized-extension@4.0.19

* fix(gutter): fix type for gutter support (#4014)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.19
 - @patternfly/react-core@4.2.7
 - @patternfly/react-docs@5.0.21
 - @patternfly/react-inline-edit-extension@4.0.22
 - demo-app-ts@4.2.7
 - @patternfly/react-integration@4.2.7
 - @patternfly/react-table@4.0.22
 - @patternfly/react-topology@4.0.20
 - @patternfly/react-virtualized-extension@4.0.20

* faster lint (#4048)

* type functional components as function components (#4050)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.20
 - @patternfly/react-core@4.2.8
 - @patternfly/react-docs@5.0.22
 - @patternfly/react-inline-edit-extension@4.0.23
 - demo-app-ts@4.2.8
 - @patternfly/react-integration@4.2.8
 - @patternfly/react-table@4.0.23
 - @patternfly/react-topology@4.0.21
 - @patternfly/react-virtualized-extension@4.0.21

* fix(packages): make imports tsc compatible (#4051)

* fix import/export default as

* use esm imports from react-core

* fix few remaining default exports

* fix selector to not rely on value of GenerateID

* fix lint

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.21
 - @patternfly/react-core@4.2.9
 - @patternfly/react-docs@5.0.23
 - @patternfly/react-inline-edit-extension@4.0.24
 - demo-app-ts@4.2.9
 - @patternfly/react-integration@4.2.9
 - @patternfly/react-table@4.0.24
 - @patternfly/react-topology@4.0.22
 - @patternfly/react-virtualized-extension@4.0.22

* feat(react-tokens): unify react-token generation (#4058)

* feat(react-tokens): unify token generation strategies

* continue to use build script

* fix build

* node 10 doesn't have array.prototype.flat

* syntax

* bump theme

* fix(popover): update default popover header size (#4030)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.22
 - @patternfly/react-charts@6.1.4
 - @patternfly/react-core@4.2.10
 - @patternfly/react-docs@5.1.0
 - @patternfly/react-inline-edit-extension@4.0.25
 - demo-app-ts@4.2.10
 - @patternfly/react-integration@4.2.10
 - @patternfly/react-table@4.0.25
 - @patternfly/react-tokens@4.1.0
 - @patternfly/react-topology@4.0.23
 - @patternfly/react-virtualized-extension@4.0.23

* fix(empty-state): add isFullHeight prop support (#4031)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.23
 - @patternfly/react-core@4.2.11
 - @patternfly/react-docs@5.1.1
 - @patternfly/react-inline-edit-extension@4.0.26
 - demo-app-ts@4.2.11
 - @patternfly/react-integration@4.2.11
 - @patternfly/react-table@4.0.26
 - @patternfly/react-topology@4.0.24
 - @patternfly/react-virtualized-extension@4.0.24

* docs(pf4): fix broken link to react-integration in contribution guide (#3996)

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

* Fix example ids for a11y (#4001)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.24
 - @patternfly/react-core@4.2.12
 - @patternfly/react-docs@5.1.2
 - @patternfly/react-inline-edit-extension@4.0.27
 - demo-app-ts@4.2.12
 - @patternfly/react-table@4.0.27
 - @patternfly/react-topology@4.0.25
 - @patternfly/react-virtualized-extension@4.0.25

* fix: PF4 Switch: label does not accept React.node (#4004)

* fix: PF4 Switch: label does not accept React.node

* react-integration demo updated for Switch

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.25
 - @patternfly/react-core@4.2.13
 - @patternfly/react-docs@5.1.3
 - @patternfly/react-inline-edit-extension@4.0.28
 - demo-app-ts@4.2.13
 - @patternfly/react-integration@4.2.12
 - @patternfly/react-table@4.0.28
 - @patternfly/react-topology@4.0.26
 - @patternfly/react-virtualized-extension@4.0.26

* feat(react-styles): standardize css-in-js generation (#4066)

* feat(react-styles): standardize css-in-js generation

* fix lint

* fix incremental build script

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.26
 - @patternfly/react-charts@6.1.5
 - @patternfly/react-core@4.2.14
 - @patternfly/react-docs@5.1.4
 - @patternfly/react-inline-edit-extension@4.0.29
 - demo-app-ts@4.2.14
 - @patternfly/react-styles@4.1.0
 - @patternfly/react-table@4.0.29
 - @patternfly/react-tokens@4.2.0
 - @patternfly/react-topology@4.0.27
 - @patternfly/react-virtualized-extension@4.0.27

* fix(table): use button element as default component for table action dropdown (#4021)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-docs@5.1.5
 - @patternfly/react-inline-edit-extension@4.0.30
 - @patternfly/react-table@4.0.30

* docs(form): change cancel buttons to link variant (#4061)

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.0.27
 - @patternfly/react-core@4.2.15
 - @patternfly/react-docs@5.1.6
 - @patternfly/react-inline-edit-extension@4.0.31
 - demo-app-ts@4.2.15
 - @patternfly/react-table@4.0.31
 - @patternfly/react-topology@4.0.28
 - @patternfly/react-virtualized-extension@4.0.28

* feat(card): support flat variation (#4026)

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

* feat(react-icons): revert to HOC, use common build system (#4069)

* feat(react-icons): revert to HOC, use common build system

* working icon build

* just use dist for now

* fix require generation

* update snapshots

* fix lint

* fix type

* more specific type

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.1.0
 - @patternfly/react-core@4.3.0
 - @patternfly/react-docs@5.1.7
 - @patternfly/react-icons@4.1.0
 - @patternfly/react-inline-edit-extension@4.1.0
 - demo-app-ts@4.3.0
 - @patternfly/react-integration@4.3.0
 - @patternfly/react-table@4.1.0
 - @patternfly/react-topology@4.1.0
 - @patternfly/react-virtualized-extension@4.1.0

* feat(react-inline-edit-extension): convert to TS (#4073)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-docs@5.1.8
 - @patternfly/react-inline-edit-extension@4.2.0

* feat(Drawer): remove flag to add border, adjust flag for no border (#4036)

* feat(Drawer): remove flag to add border, adjust flag for no border

* feat(Drawer): rename hasNoBorder to noBorder

* feat(Drawer): rename to hasNoBorder

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.1.1
 - @patternfly/react-core@4.4.0
 - @patternfly/react-docs@5.1.9
 - @patternfly/react-inline-edit-extension@4.2.1
 - demo-app-ts@4.3.1
 - @patternfly/react-table@4.1.1
 - @patternfly/react-topology@4.1.1
 - @patternfly/react-virtualized-extension@4.1.1

* Fix/3223 integration ts (#4019)

* resolved all but 18 TS errors in demo app

* applicationlauncherfavoritesdemo

* SelectDemo completed

* 7 errors left

* tablesortableforcompoundexpandabledemo workaround

* resolved FilteringSelectDemo errors

* resolved tablesortableforcompoundexpandabledemo errors

* fixed applicationlauncherfavoritesdemo error

* updated tsconfig to enable strictPropertyInitialization, noImplicitAny, strictNullChecks, and strictFunctionTypes rules

* fix 4 lint errors

* fix cypress errors in applicationlauncherfavoritesdemo

* remove inferred types from applicationlauncherfavoritesdemo

* fix cypress error in pagedemo

* fix cypress errors in selectdemo

* fix cypress error in filteringselectdemo

* reverted donututilizationchartdemo, set strictNullChecks and strictPropertyInitialization false

* chore(release): releasing packages [ci skip]

 - demo-app-ts@4.3.2
 - @patternfly/react-integration@4.3.1

* feat(title): supply defaults for title size property (#4081)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.1.2
 - @patternfly/react-core@4.5.0
 - @patternfly/react-docs@5.1.10
 - @patternfly/react-inline-edit-extension@4.2.2
 - demo-app-ts@4.4.0
 - @patternfly/react-integration@4.4.0
 - @patternfly/react-table@4.1.2
 - @patternfly/react-topology@4.1.2
 - @patternfly/react-virtualized-extension@4.1.2

* feat(ContextSelector, Select): update css name for search input (#4033)

* feat(Context Selector, Select): update search input class name

* feat(ContextSelector): update snapshots

* Remove unused props interface from EmptyStateIcon (#4065)

* chore(react-topology): replace Toolbar layout with DataToolbar (#4078)

* feat(Button): allow icon to be used in any variant, add icon css modifiers (#4032)

* feat(Button): add start/end modifiers, allow icon to be used outside of link btns

* feat(Button): update snapshots

* feat(Table): update snapshots from button changes

* feat(Button): prevent icon prop with plain variant

plain variant expects icon as child without padding

* Remove promoted components from experimental index file (#4029)

* fix(table): empty state can now scale on smaller screens (#4064)

* fixes empty state table alignment

* removes bullseye layout from empty states

* refactor(Wizard): Update string props to be React nodes. (#4063)

#2593

Co-authored-by: Titani <tlabaj@redaht.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.1.3
 - @patternfly/react-core@4.6.0
 - @patternfly/react-docs@5.1.11
 - @patternfly/react-inline-edit-extension@4.2.3
 - demo-app-ts@4.4.1
 - @patternfly/react-table@4.2.0
 - @patternfly/react-topology@4.1.3
 - @patternfly/react-virtualized-extension@4.1.3

* perf(packages): use tsc to build instead of babel (#4076)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.1.4
 - @patternfly/react-charts@6.1.6
 - @patternfly/react-core@4.6.1
 - @patternfly/react-docs@5.1.12
 - @patternfly/react-icons@4.1.1
 - @patternfly/react-inline-edit-extension@4.2.4
 - demo-app-ts@4.4.2
 - @patternfly/react-integration@4.4.1
 - @patternfly/react-styles@4.1.1
 - @patternfly/react-table@4.2.1
 - @patternfly/react-tokens@4.2.1
 - @patternfly/react-topology@4.1.4
 - @patternfly/react-virtualized-extension@4.1.4

* chore(react-docs): publish docs (#4099)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-docs@5.1.13

* Feat(Dropdown): add image & plain text support (#4038)

* added support for toggle image, added isPlainText prop

* updated example IDs and naming

* updated imports and snapshots

* missing comma

* PR feedback updates:
- renamed prop toggleIcon to toggleIndicator
- renamed prop toggleImage to icon
- updated variable names based on new props
- updated ApplicationLauncher, OptionsMenu, OptionsMenuToggle and PaginationOptionsMenu which all use either DropdownToggle or DropdownContext
- updated snapshots

* reverted styles variable names

* Additional PR feedback:
- add icon prop to integration app
- updated icon prop description

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.1.5
 - @patternfly/react-core@4.6.2
 - @patternfly/react-docs@5.1.14
 - @patternfly/react-inline-edit-extension@4.2.5
 - demo-app-ts@4.4.3
 - @patternfly/react-integration@4.4.2
 - @patternfly/react-table@4.2.2
 - @patternfly/react-topology@4.1.5
 - @patternfly/react-virtualized-extension@4.1.5

* feat(react-core): bump core and fix build (#4116)

* chore(v4): bump core

* down to 31 errors

* fix other 31 errors

* fix lint and tests

* fix more tests

* nit

* fix label demo

* fix integration tests

* update generated page snapshot

* fix page integration tests

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.2.0
 - @patternfly/react-charts@6.2.0
 - @patternfly/react-core@4.7.0
 - @patternfly/react-docs@5.2.0
 - @patternfly/react-icons@4.2.0
 - @patternfly/react-inline-edit-extension@4.3.0
 - demo-app-ts@4.5.0
 - @patternfly/react-integration@4.5.0
 - @patternfly/react-styles@4.2.0
 - @patternfly/react-table@4.3.0
 - @patternfly/react-tokens@4.3.0
 - @patternfly/react-topology@4.2.0
 - @patternfly/react-virtualized-extension@4.2.0

* fix: fix broken image links (#3960)

* chore(release): releasing packages [ci skip]

 - demo-app-ts@4.5.1
 - @patternfly/react-integration@4.5.1

* fix(version): mis-match in readme (#4121)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.2.1
 - @patternfly/react-core@4.7.1
 - @patternfly/react-docs@5.2.1
 - @patternfly/react-inline-edit-extension@4.3.1
 - demo-app-ts@4.5.2
 - @patternfly/react-table@4.3.1
 - @patternfly/react-topology@4.2.1
 - @patternfly/react-virtualized-extension@4.2.1

* Merge master from 2020.05 release (#4123)

* Merge master from 2020.05 release

* clean a little

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.2.2
 - @patternfly/react-charts@6.2.1
 - @patternfly/react-core@4.7.2
 - @patternfly/react-docs@5.2.2
 - @patternfly/react-icons@4.2.1
 - @patternfly/react-inline-edit-extension@4.3.2
 - demo-app-ts@4.5.3
 - @patternfly/react-integration@4.5.2
 - @patternfly/react-styles@4.2.1
 - @patternfly/react-table@4.3.2
 - @patternfly/react-tokens@4.3.1
 - @patternfly/react-topology@4.2.2
 - @patternfly/react-virtualized-extension@4.2.2

* feat(form): support removing top spacer form from labels (#4025)

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.2.3
 - @patternfly/react-core@4.8.0
 - @patternfly/react-docs@5.2.3
 - @patternfly/react-inline-edit-extension@4.3.3
 - demo-app-ts@4.6.0
 - @patternfly/react-integration@4.6.0
 - @patternfly/react-table@4.3.3
 - @patternfly/react-topology@4.2.3
 - @patternfly/react-virtualized-extension@4.2.3

* fix(react-docs): bump gatsby-theme to fix nav (#4126)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-docs@5.2.4

* Chore/4114 wrap icons (#4122)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.2.4
 - @patternfly/react-core@4.8.1
 - @patternfly/react-docs@5.2.5
 - @patternfly/react-inline-edit-extension@4.3.4
 - demo-app-ts@4.6.1
 - @patternfly/react-table@4.3.4
 - @patternfly/react-topology@4.2.4
 - @patternfly/react-virtualized-extension@4.2.4

* chore(readme): update react-core readme to new format (#4086)

* chore(readme): update react-core readme to new format

* chore(readme): fix root readme link

* Fix readme and remove community links

* Switch to opting in to overpass

* chore(EmptyStateIcon): update docs to reflect suggested icons (#4127)

* chore(EmptyStateIcon): update icon prop document to reflect suggested icons

* modify icon prop desc more

* fix(nav): fix scrolling (#4129)

* fix(nav): fix scrolling

* fix lint and tests

* fix mdlint

* remove correct event listener

* listen to onScroll event

* update snapshots

* fix(types): don't publish tsconfigs (#4111)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.2.5
 - @patternfly/react-charts@6.2.2
 - @patternfly/react-core@4.8.2
 - @patternfly/react-docs@5.2.6
 - @patternfly/react-icons@4.2.2
 - @patternfly/react-inline-edit-extension@4.3.5
 - demo-app-ts@4.6.2
 - @patternfly/react-styles@4.2.2
 - @patternfly/react-table@4.3.5
 - @patternfly/react-topology@4.2.5
 - @patternfly/react-virtualized-extension@4.2.5

* feat(Wizard): update hasBodyPadding (#4136)

* feat(Wizard): update hasBodyPadding

* update prop description

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.2.6
 - @patternfly/react-core@4.9.0
 - @patternfly/react-docs@5.2.7
 - @patternfly/react-inline-edit-extension@4.3.6
 - demo-app-ts@4.6.3
 - @patternfly/react-table@4.3.6
 - @patternfly/react-topology@4.2.6
 - @patternfly/react-virtualized-extension@4.2.6

* Update react-charts types (#4138)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-charts@6.2.3
 - @patternfly/react-docs@5.2.8

* fix(docs): bump theme and improve speed (#4141)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.2.7
 - @patternfly/react-core@4.9.1
 - @patternfly/react-docs@5.2.9
 - @patternfly/react-inline-edit-extension@4.3.7
 - demo-app-ts@4.6.4
 - @patternfly/react-table@4.3.7
 - @patternfly/react-topology@4.2.7
 - @patternfly/react-virtualized-extension@4.2.7

* fix(css): change gutter="x" to hasGutter (#4145)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-docs@5.2.10

* fix(drawer): toggle hidden and remove aria-hidden/expanded (#4034)

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.2.8
 - @patternfly/react-core@4.9.2
 - @patternfly/react-docs@5.2.11
 - @patternfly/react-inline-edit-extension@4.3.8
 - demo-app-ts@4.6.5
 - @patternfly/react-table@4.3.8
 - @patternfly/react-topology@4.2.8
 - @patternfly/react-virtualized-extension@4.2.8

* chore(packages): bump react peer dep to 16.8.0 (#4144)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@4.2.9
 - @patternfly/react-charts@6.2.4
 - @patternfly/react-core@4.9.3
 - @patternfly/react-docs@5.2.12
 - @patternfly/react-icons@4.2.3
 - @patternfly/react-inline-edit-extension@4.3.9
 - demo-app-ts@4.6.6
 - @patternfly/react-integration@4.6.1
 - @patternfly/react-table@4.3.9
 - @patternfly/react-topology@4.2.9
 - @patternfly/react-virtualized-extension@4.2…
@redallen redallen mentioned this pull request May 19, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evwilkin evwilkin evwilkin approved these changes

@dlabrecq dlabrecq dlabrecq approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@jschuler jschuler Awaiting requested review from jschuler

Assignees

No one assigned

Labels

Breaking change 💥 this change requires a major release and has API changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Empty State should be full width by default

5 participants

@tlabaj @patternfly-build @evwilkin @dlabrecq @kmcfaul