Skip to content

chore(prop-types): remove a few usages #3968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jschuler merged 1 commit into from
Mar 25, 2020
Merged

chore(prop-types): remove a few usages #3968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/react-core/src/helpers/componentShape.js
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions packages/react-docs/src/pages/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import React from 'react';
import PropTypes from 'prop-types';
import { graphql } from 'gatsby';
import { Title } from '@patternfly/react-core/dist/js/components/Title/Title';
import { PageSection, PageSectionVariants } from '@patternfly/react-core/dist/js/components/Page/PageSection';
Expand Down Expand Up @@ -50,11 +49,6 @@ const IndexPage = ({ data, location }) => {
);
};

IndexPage.propTypes = {
data: PropTypes.any.isRequired,
location: PropTypes.Object
};

export const pageQuery = graphql`
{
allReactCoreJson {
Expand Down
5 changes: 0 additions & 5 deletions packages/react-integration/demo-app-ts/src/components/AppSidebar/AppSidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
import React from 'react';
import PropTypes from 'prop-types';
import { PageSidebar, PageSidebarProps } from '@patternfly/react-core';

export const AppSidebar: React.FunctionComponent<PageSidebarProps> = props => <PageSidebar nav={props.nav} />;

AppSidebar.propTypes = {
nav: PropTypes.node
};

export default AppSidebar;
29 changes: 12 additions & 17 deletions scripts/generators/patternfly-4-component/templates/component/component.tsx.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,19 @@
import React, { DetailedHTMLProps } from 'react';
import * as React from 'react';
import styles from '@patternfly/react-styles/css/{{typeDir}}/{{componentName}}';
import { css } from '@patternfly/react-styles';
import PropTypes from 'prop-types';

const defaultProps = {
children: null,
className: ''
};

interface {{ componentName }}Props {
children?: any;
className?: string;
children?: any;
className?: string;
}

const {{componentName}}: React.SFC<{{componentName}}Props> = (props) => (
<div {...props} className={css(styles.{{ camelCase componentName }}, props.className)}>
{props.children}
</div>
export const {{componentName}}: React.SFC<{{componentName}}Props> = ({
className,
children
}) => {
return (
<div {...props} className={css(styles.{{ camelCase componentName }}, props.className)}>
{props.children}
</div>
);

{{ componentName }}.defaultProps = defaultProps;

export default {{ componentName }};
}