Bump Victory packages

packages/react-charts/package.json

@@ -34,9 +34,8 @@
     "@patternfly/react-tokens": "^4.0.2",
     "hoist-non-react-statics": "^3.3.0",
     "lodash": "^4.17.15",
-    "victory": "^33.0.5",
-    "victory-core": "^33.0.1",
-    "victory-legend": "^33.0.1"
+    "victory": "^34.1.3",
+    "victory-core": "^34.1.3"
   },
   "peerDependencies": {
     "prop-types": "^15.6.1",
@@ -62,7 +61,7 @@
     "@babel/preset-env": "^7.0.0",
     "@babel/preset-react": "^7.0.0",
     "@types/lodash": "^4.14.138",
-    "@types/victory": "^31.0.22",
+    "@types/victory": "^33.1.4",
     "babel-plugin-transform-es2015-modules-umd": "^6.24.1",
     "babel-plugin-typescript-to-proptypes": "^0.17.1",
     "css": "^2.2.3",

packages/react-charts/src/components/Chart/Chart.tsx

@@ -446,7 +446,10 @@ export const Chart: React.FunctionComponent<ChartProps> = ({
     });
   };
 
+  // Note: containerComponent is required for theme, but @types/victory is missing a prop type
   return (
+    // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
+    // @ts-ignore
     <VictoryChart
       containerComponent={container}
       height={height}

packages/react-charts/src/components/ChartArea/ChartArea.tsx

@@ -402,7 +402,13 @@ export const ChartArea: React.FunctionComponent<ChartAreaProps> = ({
     theme,
     ...containerComponent.props
   });
-  return <VictoryArea containerComponent={container} theme={theme} {...rest} />;
+
+  // Note: containerComponent is required for theme, but @types/victory is missing a prop type
+  return (
+    // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
+    // @ts-ignore
+    <VictoryArea containerComponent={container} theme={theme} {...rest} />
+  );
 };
 
 // Note: VictoryArea.role must be hoisted

packages/react-charts/src/components/ChartAxis/ChartAxis.tsx

@@ -420,7 +420,11 @@ export const ChartAxis: React.FunctionComponent<ChartAxisProps> = ({
     theme,
     ...containerComponent.props
   });
+
+  // Note: containerComponent is required for theme, but @types/victory is missing a prop type
   return (
+    // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
+    // @ts-ignore
     <VictoryAxis
       containerComponent={container}
       theme={showGrid ? getAxisTheme(themeColor, themeVariant) : theme}

packages/react-charts/src/components/ChartBar/ChartBar.tsx

@@ -429,7 +429,13 @@ export const ChartBar: React.FunctionComponent<ChartBarProps> = ({
     theme,
     ...containerComponent.props
   });
-  return <VictoryBar containerComponent={container} theme={theme} {...rest} />;
+
+  // Note: containerComponent is required for theme, but @types/victory is missing a prop type
+  return (
+    // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
+    // @ts-ignore
+    <VictoryBar containerComponent={container} theme={theme} {...rest} />
+  );
 };
 
 // Note: VictoryBar.getDomain & VictoryBar.role must be hoisted

packages/react-charts/src/components/ChartBullet/ChartBulletComparativeMeasure.tsx

@@ -198,14 +198,14 @@ export const ChartBulletComparativeMeasure: React.FunctionComponent<ChartBulletC
       if (horizontal) {
         return 0;
       }
-      const result = typeof barWidth === 'function' ? barWidth(data, false) : barWidth;
+      const result = typeof barWidth === 'function' ? barWidth(data as any) : barWidth;
       return result / 2;
     },
     dy: () => {
       if (!horizontal) {
         return 0;
       }
-      const result = typeof barWidth === 'function' ? barWidth(data, false) : barWidth;
+      const result = typeof barWidth === 'function' ? barWidth(data as any) : barWidth;
       return -(result / 2);
     },
     orientation: 'top',

packages/react-charts/src/components/ChartBullet/ChartBulletPrimarySegmentedMeasure.tsx

@@ -224,14 +224,14 @@ export const ChartBulletPrimarySegmentedMeasure: React.FunctionComponent<ChartBu
       if (horizontal) {
         return 0;
       }
-      const result = typeof barWidth === 'function' ? barWidth(data, false) : barWidth;
+      const result = typeof barWidth === 'function' ? barWidth(data as any) : barWidth;
       return result / 2;
     },
     dy: () => {
       if (!horizontal) {
         return 0;
       }
-      const result = typeof barWidth === 'function' ? barWidth(data, false) : barWidth;
+      const result = typeof barWidth === 'function' ? barWidth(data as any) : barWidth;
       return -(result / 2);
     },
     orientation: 'top',

packages/react-charts/src/components/ChartBullet/ChartBulletQualitativeRange.tsx

@@ -235,14 +235,14 @@ export const ChartBulletQualitativeRange: React.FunctionComponent<ChartBulletQua
       if (horizontal) {
         return 0;
       }
-      const result = typeof barWidth === 'function' ? barWidth(data, false) : barWidth;
+      const result = typeof barWidth === 'function' ? barWidth(data as any) : barWidth;
       return result / 2;
     },
     dy: () => {
       if (!horizontal) {
         return 0;
       }
-      const result = typeof barWidth === 'function' ? barWidth(data, false) : barWidth;
+      const result = typeof barWidth === 'function' ? barWidth(data as any) : barWidth;
       return -(result / 2);
     },
     orientation: 'top',

packages/react-charts/src/components/ChartGroup/ChartGroup.tsx

@@ -436,7 +436,11 @@ export const ChartGroup: React.FunctionComponent<ChartGroupProps> = ({
     ...containerComponent.props,
     className: getClassName({ className: containerComponent.props.className }) // Override VictoryContainer class name
   });
+
+  // Note: containerComponent is required for theme, but @types/victory is missing a prop type
   return (
+    // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
+    // @ts-ignore
     <VictoryGroup containerComponent={container} theme={theme} {...rest}>
       {children}
     </VictoryGroup>

packages/react-charts/src/components/ChartLegend/ChartLegend.tsx

@@ -303,7 +303,13 @@ export const ChartLegend: React.FunctionComponent<ChartLegendProps> = ({
     theme,
     ...containerComponent.props
   });
-  return <VictoryLegend containerComponent={container} dataComponent={dataComponent} theme={theme} {...rest} />;
+
+  // Note: containerComponent is required for theme, but @types/victory is missing a prop type
+  return (
+    // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
+    // @ts-ignore
+    <VictoryLegend containerComponent={container} dataComponent={dataComponent} theme={theme} {...rest} />
+  );
 };
 
 // Note: VictoryLegend.role must be hoisted, but getBaseProps causes error with ChartVoronoiContainer

packages/react-charts/src/components/ChartLine/ChartLine.tsx

@@ -399,7 +399,12 @@ export const ChartLine: React.FunctionComponent<ChartLineProps> = ({
     theme,
     ...containerComponent.props
   });
-  return <VictoryLine containerComponent={container} theme={theme} {...rest} />;
+  // Note: containerComponent is required for theme, but @types/victory is missing a prop type
+  return (
+    // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
+    // @ts-ignore
+    <VictoryLine containerComponent={container} theme={theme} {...rest} />
+  );
 };
 
 // Note: VictoryLine.role must be hoisted

packages/react-charts/src/components/ChartPie/ChartPie.tsx

@@ -466,7 +466,7 @@ export const ChartPie: React.FunctionComponent<ChartPieProps> = ({
       standalone={false}
       theme={theme}
       width={width}
-      {...rest}
+      {...(rest as any)} // @types/victory has a type mismatch with colorScale
     />
   );
 

packages/react-charts/src/components/ChartScatter/ChartScatter.tsx

@@ -417,7 +417,13 @@ export const ChartScatter: React.FunctionComponent<ChartScatterProps> = ({
     theme,
     ...containerComponent.props
   });
-  return <VictoryScatter containerComponent={container} size={size} theme={theme} {...rest} />;
+
+  // Note: containerComponent is required for theme, but @types/victory is missing a prop type
+  return (
+    // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
+    // @ts-ignore
+    <VictoryScatter containerComponent={container} size={size} theme={theme} {...rest} />
+  );
 };
 
 // Note: VictoryLine.role must be hoisted

packages/react-charts/src/components/ChartStack/ChartStack.tsx

@@ -364,7 +364,11 @@ export const ChartStack: React.FunctionComponent<ChartStackProps> = ({
     ...containerComponent.props,
     className: getClassName({ className: containerComponent.props.className }) // Override VictoryContainer class name
   });
+
+  // Note: containerComponent is required for theme, but @types/victory is missing a prop type
   return (
+    // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
+    // @ts-ignore
     <VictoryStack containerComponent={container} theme={theme} {...rest}>
       {children}
     </VictoryStack>