Skip to content

fix(popover): update default popover header size #4030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redallen merged 1 commit into from
Apr 13, 2020
Merged

fix(popover): update default popover header size #4030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Popover/PopoverHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export const PopoverHeader: React.FunctionComponent<PopoverHeaderProps> = ({
id,
...props
}: PopoverHeaderProps) => (
<Title headingLevel="h6" size={TitleSizes.xl} id={id} {...props}>
<Title headingLevel="h6" size={TitleSizes.md} id={id} {...props}>
{children}
</Title>
);
Expand Down
2 changes: 1 addition & 1 deletion ...core/src/components/Popover/__tests__/Generated/__snapshots__/PopoverHeader.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ exports[`PopoverHeader should match snapshot (auto-generated) 1`] = `
<Title
headingLevel="h6"
id="string"
size="xl"
size="md"
>
<div>
ReactNode
Expand Down
8 changes: 8 additions & 0 deletions packages/react-integration/cypress/integration/popover.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,12 @@ describe('Popover Demo Test', () => {
});
});
});

it('Popover header has correct default size', () => {
cy.get('div[id="popoverTarget"]').then((popoverLink: JQuery<HTMLDivElement>) => {
cy.wrap(popoverLink).click();
cy.get('.tippy-popper').should('exist');
cy.get('h6').should('have.class', 'pf-m-md');
});
});
});