Skip to content

feat(Drawer): remove flag to add border, adjust flag for no border #4036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redallen merged 3 commits into from
Apr 15, 2020
Merged

feat(Drawer): remove flag to add border, adjust flag for no border #4036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9eddf3
feat(Drawer): remove flag to add border, adjust flag for no border
kmcfaul Apr 7, 2020
70b3047
feat(Drawer): rename hasNoBorder to noBorder
kmcfaul Apr 8, 2020
c2d4931
feat(Drawer): rename to hasNoBorder
kmcfaul Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/react-core/src/components/Drawer/DrawerPanelContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ export interface DrawerPanelContentProps extends React.HTMLProps<HTMLDivElement>
className?: string;
/** Content to be rendered in the drawer panel. */
children?: React.ReactNode;
/* Flag indicating that the drawer panel should have a border. */
hasBorder?: boolean;
/* Flag indicating that the drawer panel should not have a border. */
hasNoBorder?: boolean;
/* Default width for drawer panel */
width?: 25 | 33 | 50 | 66 | 75 | 100;
/* Drawer panel width on large viewports */
Expand All @@ -23,7 +23,7 @@ export interface DrawerPanelContentProps extends React.HTMLProps<HTMLDivElement>
export const DrawerPanelContent: React.SFC<DrawerPanelContentProps> = ({
className = '',
children,
hasBorder = false,
hasNoBorder = false,
width,
widthOnLg,
widthOnXl,
Expand All @@ -35,7 +35,7 @@ export const DrawerPanelContent: React.SFC<DrawerPanelContentProps> = ({
<div
className={css(
styles.drawerPanel,
!hasBorder && styles.modifiers.noBorder,
hasNoBorder && styles.modifiers.noBorder,
width && styles.modifiers[`width_${width}` as keyof typeof styles.modifiers],
widthOnLg && styles.modifiers[`width_${widthOnLg}OnLg` as keyof typeof styles.modifiers],
widthOnXl && styles.modifiers[`width_${widthOnXl}OnXl` as keyof typeof styles.modifiers],
Expand Down
10 changes: 5 additions & 5 deletions packages/react-core/src/components/Drawer/__tests__/__snapshots__/Drawer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ exports[`Drawer isExpanded = false and isInline = false and isStatic = false 1`]
<div
aria-expanded={false}
aria-hidden={true}
className="pf-c-drawer__panel pf-m-no-border"
className="pf-c-drawer__panel"
hidden={true}
>
<DrawerHead>
Expand Down Expand Up @@ -191,7 +191,7 @@ exports[`Drawer isExpanded = false and isInline = true and isStatic = false 1`]
<div
aria-expanded={false}
aria-hidden={true}
className="pf-c-drawer__panel pf-m-no-border"
className="pf-c-drawer__panel"
hidden={true}
>
<DrawerHead>
Expand Down Expand Up @@ -339,7 +339,7 @@ exports[`Drawer isExpanded = true and isInline = false and isStatic = false 1`]
<div
aria-expanded={true}
aria-hidden={false}
className="pf-c-drawer__panel pf-m-no-border"
className="pf-c-drawer__panel"
hidden={false}
>
<DrawerHead>
Expand Down Expand Up @@ -487,7 +487,7 @@ exports[`Drawer isExpanded = true and isInline = false and isStatic = true 1`] =
<div
aria-expanded={true}
aria-hidden={false}
className="pf-c-drawer__panel pf-m-no-border"
className="pf-c-drawer__panel"
hidden={false}
>
<DrawerHead>
Expand Down Expand Up @@ -635,7 +635,7 @@ exports[`Drawer isExpanded = true and isInline = true and isStatic = false 1`] =
<div
aria-expanded={true}
aria-hidden={false}
className="pf-c-drawer__panel pf-m-no-border"
className="pf-c-drawer__panel"
hidden={false}
>
<DrawerHead>
Expand Down
Loading