Skip to content

fix(table): empty state can now scale on smaller screens #4064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redallen merged 2 commits into from
Apr 17, 2020
Merged

fix(table): empty state can now scale on smaller screens #4064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9298e6
fixes empty state table alignment
jenny-s51 Apr 13, 2020
8f366af
removes bullseye layout from empty states
jenny-s51 Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/react-core/src/demos/TableEmptyStatesDemo.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ class EmptyStateDemo extends React.Component {
<TableHeader />
<TableBody />
</Table>
<Bullseye>
<EmptyState>
<EmptyStateIcon icon={SearchIcon} />
<Title headingLevel="h5" size="lg">
Expand All @@ -65,7 +64,6 @@ class EmptyStateDemo extends React.Component {
</Button>
</EmptyStateSecondaryActions>
</EmptyState>
</Bullseye>
</React.Fragment>
);
}
Expand Down Expand Up @@ -96,9 +94,7 @@ class LoadingStateDemo extends React.Component {
{
props: { colSpan: 8 },
title: (
<Bullseye>
<center><Spinner size="xl"/></center>
</Bullseye>
)
},
]
Expand Down Expand Up @@ -147,7 +143,6 @@ class LoadingStateDemo extends React.Component {
{
props: { colSpan: 8 },
title: (
<Bullseye>
<EmptyState variant={EmptyStateVariant.small}>
<EmptyStateIcon icon={ExclamationCircleIcon} color={globalDangerColor200.value} />
<Title headingLevel="h2" size="lg">
Expand All @@ -157,7 +152,6 @@ class LoadingStateDemo extends React.Component {
There was an error retrieving data. Check your connection and try again.
</EmptyStateBody>
</EmptyState>
</Bullseye>
)
},
]
Expand Down
37 changes: 14 additions & 23 deletions packages/react-table/src/components/Table/Table.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1249,34 +1249,25 @@ import { Button, EmptyState, EmptyStateBody, EmptyStatePrimary, Bullseye, Title
import { EmptyStateIcon } from '@patternfly/react-icons';

EmptyStateTable = () => {
const columns = ['Repositories', 'Branches', 'Pull request', 'Workspaces', 'LastCommit']
const rows = [{
heightAuto: true,
cells: [
{
props: { colSpan: 8 },
title: (
<Bullseye>
<EmptyState variant={EmptyStateVariant.small}>
<EmptyStateIcon icon={SearchIcon} />
<Title headingLevel="h2" size="lg">
No results found
</Title>
<EmptyStateBody>
No results match the filter criteria. Remove all filters or clear all filters to show results.
</EmptyStateBody>
<Button variant="link">Clear all filters</Button>
</EmptyState>
</Bullseye>
)
},
]
}]
const columns = ['Repositories', 'Branches', 'Pull requests', 'Workspaces', 'Last Commit']
const rows = []
return (
<React.Fragment>
<Table caption="Empty State Table Example" cells={columns} rows={rows}>
<TableHeader />
<TableBody />
</Table>
<EmptyState variant={EmptyStateVariant.small}>
<EmptyStateIcon icon={SearchIcon} />
<Title headingLevel="h2" size="lg">
No results found
</Title>
<EmptyStateBody>
No results match the filter criteria. Remove all filters or clear all filters to show results.
</EmptyStateBody>
<Button variant="link">Clear all filters</Button>
</EmptyState>
</React.Fragment>
);
}
```
Expand Down