Skip to content

feat(react-icons): revert to HOC, use common build system #4069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evwilkin merged 8 commits into from
Apr 14, 2020
Merged

feat(react-icons): revert to HOC, use common build system #4069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f9a2116
feat(react-icons): revert to HOC, use common build system
redallen Apr 13, 2020
fb5e7e1
working icon build
redallen Apr 14, 2020
d8bb2fc
just use dist for now
redallen Apr 14, 2020
027abe8
fix require generation
redallen Apr 14, 2020
82ed0bd
update snapshots
redallen Apr 14, 2020
b6f1663
fix lint
redallen Apr 14, 2020
f9c8e11
fix type
redallen Apr 14, 2020
ab618c2
more specific type
redallen Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
413 changes: 175 additions & 238 deletions ...catalog-view-extension/src/components/CatalogTile/__snapshots__/CatalogTile.test.tsx.snap
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 5 additions & 1 deletion ...nents/AboutModal/__tests__/Generated/__snapshots__/AboutModalBoxCloseButton.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ exports[`AboutModalBoxCloseButton should match snapshot (auto-generated) 1`] = `
onClick={[Function]}
variant="plain"
>
<TimesIcon />
<TimesIcon
color="currentColor"
noVerticalAlign={false}
size="sm"
/>
</Button>
</div>
`;
18 changes: 15 additions & 3 deletions .../src/components/AboutModal/__tests__/__snapshots__/AboutModalBoxCloseButton.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ exports[`AboutModalBoxCloseButton Test 1`] = `
onClick={[Function]}
variant="plain"
>
<TimesIcon />
<TimesIcon
color="currentColor"
noVerticalAlign={false}
size="sm"
/>
</Button>
</div>
`;
Expand All @@ -23,7 +27,11 @@ exports[`AboutModalBoxCloseButton Test close button aria label 1`] = `
onClick={[Function]}
variant="plain"
>
<TimesIcon />
<TimesIcon
color="currentColor"
noVerticalAlign={false}
size="sm"
/>
</Button>
</div>
`;
Expand All @@ -37,7 +45,11 @@ exports[`AboutModalBoxCloseButton Test onclose 1`] = `
onClick={[MockFunction]}
variant="plain"
>
<TimesIcon />
<TimesIcon
color="currentColor"
noVerticalAlign={false}
size="sm"
/>
</Button>
</div>
`;
6 changes: 5 additions & 1 deletion ...react-core/src/components/Alert/__tests__/Generated/__snapshots__/AlertIcon.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ exports[`AlertIcon should match snapshot (auto-generated) 1`] = `
<div
className="pf-c-alert__icon ''"
>
<CheckCircleIcon />
<CheckCircleIcon
color="currentColor"
noVerticalAlign={false}
size="sm"
/>
</div>
`;
Loading