feat(datalist): add the breakpointMods prop #4130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
PF4 preview: https://patternfly-react-pr-4130.surge.sh |
tlabaj
previously requested changes
Apr 27, 2020
packages/react-core/src/components/DataList/DataListActionBreakpoints.ts
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/DataList/DataListActionBreakpoints.ts
Outdated
Show resolved
Hide resolved
dlabrecq
approved these changes
Apr 28, 2020
redallen
suggested changes
May 4, 2020
Contributor
redallen
left a comment
redallen
left a comment
There was a problem hiding this comment.
One more conflict and we can get this in...
redallen
suggested changes
May 5, 2020
Contributor
redallen
left a comment
redallen
left a comment
There was a problem hiding this comment.
Cleanup types for the docs and this is good!
packages/react-core/src/components/DataList/DataListActionBreakpoints.ts
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/DataList/DataListActionBreakpoints.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
redallen
approved these changes
May 5, 2020
kmcfaul
approved these changes
May 7, 2020
Contributor
|
I fixed the merge conflict in |
Contributor
|
It worked but the linting did not, lol. Trying again... |
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Member
Author
|
Thanks @redallen ! You rock! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #3883