Skip to content

Conversation

@evwilkin
Copy link
Member

@evwilkin evwilkin commented Apr 28, 2020

What: Closes #4112

This PR updates the DropdownItem component to take an icon prop to mirror the pattern used in #4038. This change removes the need for DropdownItemIcon component, that component is removed completely.

Breaking changes

  • Dropdown:
    • Remove DropdownItemIcon in favor of <DropdownItem icon={} />
    • Remove variant prop from DropdownItem. If you were using variant="icon" before, use the new icon prop instead.

@patternfly-build
Copy link
Collaborator

patternfly-build commented Apr 28, 2020

@evwilkin evwilkin force-pushed the chore/4112-dropdownitem-icon branch from d93c23d to e898003 Compare April 28, 2020 21:10
@evwilkin evwilkin requested review from jschuler and tlabaj April 28, 2020 21:34
Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update! LGTM 🙂

@redallen
Copy link
Contributor

redallen commented Apr 30, 2020

Can you add this to your PR body's text to something like this?

## Breaking changes
- **Dropdown:**
  - Remove DropdownItemIcon in favor of <DropdownItem icon={<Icon />} />
  - Remove variant prop from DropdownItem. If you were using variant="icon" before, use the new icon prop instead.

Copy link
Contributor

@redallen redallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the PR body and then next step is to write a codemod :)

@redallen redallen merged commit 11d61f9 into patternfly:v4 Apr 30, 2020
@patternfly-build
Copy link
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@4.2.11
  • @patternfly/react-core@4.9.5
  • @patternfly/react-docs@5.2.15
  • @patternfly/react-inline-edit-extension@4.3.11
  • demo-app-ts@4.6.8
  • @patternfly/react-integration@4.6.3
  • @patternfly/react-table@4.3.11
  • @patternfly/react-topology@4.2.11
  • @patternfly/react-virtualized-extension@4.2.11

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update DropdownItem to take icon prop

5 participants