-
Notifications
You must be signed in to change notification settings - Fork 377
Chore/4112 dropdownitem icon #4147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/4112 dropdownitem icon #4147
Conversation
|
PF4 preview: https://patternfly-react-pr-4147.surge.sh |
…pdownItemIcon component, updated examples
…in Divider component
d93c23d to
e898003
Compare
jenny-s51
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great update! LGTM 🙂
|
Can you add this to your PR body's text to something like this? |
redallen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the PR body and then next step is to write a codemod :)
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #4112
This PR updates the DropdownItem component to take an
iconprop to mirror the pattern used in #4038. This change removes the need for DropdownItemIcon component, that component is removed completely.Breaking changes