Skip to content

Conversation

@evwilkin
Copy link
Member

@evwilkin evwilkin commented Apr 30, 2020

What:
Closes #3223
Closes #3230

This PR enables strictNullChecks and strictPropertyInitialization.

These were the only sub-rules of strict mode that were disabled, so this also cleans up tsconfig by removing unnecessary sub-rules in favor of simply strict: true:

noImplicitAny
noImplicitThis
alwaysStrict
strictBindCallApply
strictNullChecks
strictFunctionTypes
strictPropertyInitialization

Additional issues:
Follow-up to work done in #4019
Enabled by updates to react-charts in #4138

@patternfly-build
Copy link
Collaborator

patternfly-build commented Apr 30, 2020

@redallen redallen merged commit 19262d7 into patternfly:v4 Apr 30, 2020
@patternfly-build
Copy link
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@4.2.10
  • @patternfly/react-core@4.9.4
  • @patternfly/react-docs@5.2.14
  • @patternfly/react-icons@4.2.4
  • @patternfly/react-inline-edit-extension@4.3.10
  • demo-app-ts@4.6.7
  • @patternfly/react-integration@4.6.2
  • @patternfly/react-table@4.3.10
  • @patternfly/react-topology@4.2.10
  • @patternfly/react-virtualized-extension@4.2.10

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some component demos don't meet "strictNullChecks" requirements react-integration compiler options masks type issues

4 participants