Skip to content

Conversation

@jessiehuff
Copy link
Contributor

What: Closes #3961
Simple update to tooltip examples to allow them to be keyboard accessible.

(Same as #3962 that got accidentally reverted.)

@jessiehuff jessiehuff changed the title Add tabIndex to make tooltip examples keyboard accessible Tooltip examples should be made keyboard accessible Apr 30, 2020
@jessiehuff jessiehuff changed the title Tooltip examples should be made keyboard accessible Make tooltip examples keyboard accessible Apr 30, 2020
@patternfly-build
Copy link
Collaborator

patternfly-build commented Apr 30, 2020

@codecov-io
Copy link

Codecov Report

Merging #4157 into v4 will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v4    #4157      +/-   ##
==========================================
- Coverage   58.72%   58.71%   -0.01%     
==========================================
  Files         397      397              
  Lines        6008     6009       +1     
  Branches     2349     2350       +1     
==========================================
  Hits         3528     3528              
  Misses       2024     2024              
- Partials      456      457       +1     
Flag Coverage Δ
#patternfly4 58.71% <50.00%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...ckages/react-charts/src/components/Chart/Chart.tsx 51.51% <ø> (ø)
...eact-charts/src/components/ChartArea/ChartArea.tsx 100.00% <ø> (ø)
...eact-charts/src/components/ChartAxis/ChartAxis.tsx 87.50% <ø> (ø)
.../react-charts/src/components/ChartBar/ChartBar.tsx 100.00% <ø> (ø)
...-charts/src/components/ChartBullet/ChartBullet.tsx 58.42% <ø> (ø)
...ChartBullet/ChartBulletComparativeErrorMeasure.tsx 91.66% <ø> (ø)
...ents/ChartBullet/ChartBulletComparativeMeasure.tsx 61.53% <ø> (ø)
...artBullet/ChartBulletComparativeWarningMeasure.tsx 91.66% <ø> (ø)
...nents/ChartBullet/ChartBulletPrimaryDotMeasure.tsx 85.00% <ø> (ø)
...ChartBullet/ChartBulletPrimarySegmentedMeasure.tsx 64.28% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f287ab...485514c. Read the comment docs.

@redallen redallen merged commit 154ebc6 into patternfly:v4 Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tooltip examples should be made keyboard accessible

5 participants