fix(datatoolbar): finish rename in docs and fix context #4175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redallen
force-pushed
the
fix/datatoolbar-docs
branch
from
db408a7 to
3b6af0f
Compare
Collaborator
|
PF4 preview: https://patternfly-react-pr-4175.surge.sh |
redallen
force-pushed
the
fix/datatoolbar-docs
branch
from
ccbd722 to
5444ef1
Compare
redallen
requested review from
evwilkin,
jschuler,
nicolethoen,
seanforyou23 and
tlabaj
seanforyou23
reviewed
May 4, 2020
...ct-topology/src/components/TopologyControlBar/__snapshots__/TopologyControlBar.test.tsx.snap
Outdated
Show resolved
Hide resolved
redallen
force-pushed
the
fix/datatoolbar-docs
branch
from
30b8356 to
16f6301
Compare
seanforyou23
approved these changes
May 4, 2020
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Rename
DataToolbar.md->Toolbar.md. Allow passing components other than<ToolbarContent>to<Toolbar>by adding toolbar props to<ToolbarContext>.Closes patternfly/patternfly-org#1830
Closes #3671
Closes #4149
Additional issues: