feat(drawer): use the breakpoint mods prop instead of width props #4270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
PF4 preview: https://patternfly-react-pr-4270.surge.sh |
redallen
suggested changes
May 20, 2020
Contributor
redallen
left a comment
redallen
left a comment
There was a problem hiding this comment.
Just some type problems and nit but other than that LGTM
packages/react-core/src/components/Drawer/DrawerPanelContent.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Drawer/DrawerPanelContent.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Drawer/DrawerPanelContent.tsx
Outdated
Show resolved
Hide resolved
| 66: 'width_66', | ||
| 75: 'width_75', | ||
| 100: 'width_100' | ||
| } as const; |
Contributor
There was a problem hiding this comment.
Don't think you need as const? Maybe just make an enum?
Member
Author
There was a problem hiding this comment.
Enum key cannot be a numerical value. 😭
packages/react-core/src/components/Drawer/DrawerPanelContent.tsx
Outdated
Show resolved
Hide resolved
nicolethoen
reviewed
May 21, 2020
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
redallen
approved these changes
May 21, 2020
| breakpointMods | ||
| .map(mod => `${mod.modifier}${mod.breakpoint ? `-on-${mod.breakpoint}` : ''}`) | ||
| .map(toCamel) | ||
| .map(mod => mod.replace(/-2xl$/gi, '_2xl')) |
Contributor
There was a problem hiding this comment.
Thanks for fixing this! I've been forgetting to go back and do it.
Member
Author
|
Thank you so much! @nicolethoen @redallen 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #4238
//cc @redallen