docs(CONTRIBUTING.md): update the links to avoid 404 error (#4316) #4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

DaoDaoNoCode wants to merge 2 commits into patternfly:master from DaoDaoNoCode:issue4316

Contributor

DaoDaoNoCode commented Jun 3, 2020

What: Closes #4316


          docs(CONTRIBUTING.md): update the links to avoid 404 error (patternfl…

c933737

…y#4316)

Collaborator

patternfly-build commented Jun 3, 2020 •

edited

Loading

PF4 preview: https://patternfly-react-pr-4323.surge.sh
A11y report: https://patternfly-react-pr-4323-coverage.surge.sh

rabajaj0509 commented Jun 4, 2020

LGTM :)

jcaianirh suggested changes

View reviewed changes

Contributor

jcaianirh left a comment

@DaoDaoNoCode for this .md file, it looks like there isn't just a single 404...if you double check the others, you'll find additional 404s that need attention as well.


          docs(CONTRIBUTING.md): update all the links

cef02af

Contributor Author

DaoDaoNoCode commented Jun 4, 2020

@jcaianirh I have checked all the links and updated them. PTAL, thanks.

redallen suggested changes

View reviewed changes

Contributor

redallen left a comment

I think this overlapped with #4332 some. Need to fix merge conflicts!

Contributor Author

DaoDaoNoCode commented Jun 8, 2020

I think this overlapped with #4332 some. Need to fix merge conflicts!

Seems the issue is solved. I will close this PR!

DaoDaoNoCode closed this

DaoDaoNoCode deleted the issue4316 branch

June 8, 2020 14:17

mcarrano mentioned this pull request

Notification drawer demo #4535

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet