Merged
Conversation
Collaborator
|
PF4 preview: https://patternfly-react-pr-4371.surge.sh |
This uses the existing legend component so theme color scales and legend symbols are synced with the chart. Fixes patternfly#3219
dlabrecq
force-pushed
the
3219-tooltip-legend
branch
from
63a6f9b to
4e9e122
Compare
redallen
approved these changes
Jun 11, 2020
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for a legend tooltip. Reviewed the design with @nlcwong.
This uses the existing legend component so theme color scales and legend symbols are synced with the chart.
Created a few components and utilities to make this easier for others to implement. Although, I had to override Victory's flyout (aka the tooltip container) to get the pointer orientation working the way Natalie wanted in her mocks.
Fixes #3219
To help visualize the code, this is an abstract of my structure. I simply override label components to customize the tooltip and add the existing legend component inside the flyout. Although, I've wrapped this with new components to encapsulate functionality.