feat(Hint): add hint components #4595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
PF4 preview: https://patternfly-react-pr-4595.surge.sh |
tlabaj
reviewed
Jul 21, 2020
Contributor
tlabaj
left a comment
tlabaj
left a comment
There was a problem hiding this comment.
Looks good. I would just spread the props at the end.
Contributor
Author
|
I updated the spread, and also added |
dlabrecq
approved these changes
Jul 23, 2020
mcarrano
reviewed
Jul 28, 2020
Member
mcarrano
left a comment
mcarrano
left a comment
There was a problem hiding this comment.
Looks good to me. @maryshak1996 can you also confirm that this is what you expect?
|
Looks good to me! |
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #4525