feat(Button): add cta/large modifier #4596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
PF4 preview: https://patternfly-react-pr-4596.surge.sh |
jenny-s51
approved these changes
Jul 22, 2020
dlabrecq
approved these changes
Jul 23, 2020
tlabaj
approved these changes
Jul 28, 2020
| /** Adds small styling to the button */ | ||
| isSmall?: boolean; | ||
| /** Adds large styling to the button */ | ||
| isLarge?: boolean; |
Contributor
There was a problem hiding this comment.
In retrospect we probably should have combined the isLarge and isSmall.
Contributor
Author
There was a problem hiding this comment.
Maybe in the next breaking change release we can refactor them into a size property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #4527