Skip to content

Conversation

@kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Aug 5, 2020

What: Closes #4664

Check preventing typeahead variants' key inputs reaching the other variants' open/close logic was removed.

@patternfly-build
Copy link
Collaborator

patternfly-build commented Aug 5, 2020

redallen
redallen previously approved these changes Aug 5, 2020
@jschuler
Copy link
Collaborator

jschuler commented Aug 5, 2020

Nice, looks like the previous regression (47fec7c) that this fixes was accidentally introduced out of the desire to prevent the Enter key from submitting a form, e.g. if you have

<form onSubmit={() => alert('submitted')}>
  <Select />
</form>

. Perhaps that needs to be re-addressed in a future PR

jschuler
jschuler previously approved these changes Aug 5, 2020
@kmcfaul kmcfaul dismissed stale reviews from jschuler and redallen via 05401b4 August 5, 2020 16:09
@kmcfaul
Copy link
Contributor Author

kmcfaul commented Aug 5, 2020

@jschuler I see, possibly needs a flag to hit a preventDefault in that case. We have FormSelect for form use cases I believe as well.

@redallen redallen merged commit 3635f26 into patternfly:master Aug 5, 2020
@patternfly-build
Copy link
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@4.8.1
  • @patternfly/react-core@4.40.0
  • @patternfly/react-docs@5.8.1
  • @patternfly/react-inline-edit-extension@4.5.57
  • demo-app-ts@4.29.0
  • @patternfly/react-integration@4.29.0
  • @patternfly/react-table@4.15.1
  • @patternfly/react-topology@4.4.59
  • @patternfly/react-virtualized-extension@4.5.47

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typeahead regression

4 participants