Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-styles): support esm import and export #7084

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

kunyan
Copy link
Contributor

@kunyan kunyan commented Mar 18, 2022

The previous version are using require(), which is not fully
support esm

Add esm only output to support some pure esm project like vite or
snowpack

What: Closes #

Closes #7054

Additional issues:

The previous version are using `require()`, which is not fully
support esm

Add esm only output to support some pure esm project like vite or
snowpack
@patternfly-build
Copy link
Contributor

patternfly-build commented Mar 21, 2022

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot checked a bunch of components, everything looks good to me!

@nicolethoen nicolethoen merged commit b66ea14 into patternfly:main Apr 11, 2022
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • eslint-plugin-patternfly-react@4.41.22
  • @patternfly/react-catalog-view-extension@4.53.22
  • @patternfly/react-charts@6.55.22
  • @patternfly/react-code-editor@4.43.22
  • @patternfly/react-console@4.53.22
  • @patternfly/react-core@4.202.22
  • @patternfly/react-docs@5.63.22
  • @patternfly/react-icons@4.53.22
  • @patternfly/react-inline-edit-extension@4.47.22
  • demo-app-ts@4.162.22
  • @patternfly/react-integration@4.164.22
  • @patternfly/react-log-viewer@4.47.22
  • @patternfly/react-styles@4.52.22
  • @patternfly/react-table@4.71.22
  • @patternfly/react-tokens@4.54.22
  • @patternfly/react-topology@4.49.22
  • @patternfly/react-virtualized-extension@4.49.22
  • transformer-cjs-imports@4.40.22

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide ESM export for @patternfly/react-styles css components.
5 participants