feat(component): introduce the pf4 switch component

[guillaumevincent]

fix #728

[guillaumevincent]

I'm waiting for the switch component to be released in patternfly-core

[patternfly-build]

PatternFly-React preview: https://761-pr-patternfly-react-patternfly.surge.sh

[amarie401]

cc: @maryshak1996

[maryshak1996]

@guillaumevincent on my end, it isn't showing the element (must not be available in core yet), so I'll check back to review visuals frequently to keep things moving :)

[LHinson]

This was a convo on slack but adding here to make sure everyone saw....

the pf-next commit message didn't include a space after fix(topic):asdfdsfads therefore travis is saying there are no changes that should be included and it didn't kick off a release.

Once another proper commit is made to core, the switch should be available with that release. @dgutride will be adding stricter rules to help enforce proper commit messages and improve the releases.

[coveralls]

Pull Request Test Coverage Report for Build 3233

• 8 of 10 (80.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.006%) to 81.192%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/patternfly-4/react-core/src/components/Switch/Switch.js	8	10	80.0%

Totals
Change from base Build 3219:	0.006%
Covered Lines:	3795
Relevant Lines:	4406

---

💛 - Coveralls

[guillaumevincent]

I don't know why PatternFly-React preview is not updated, but this PR is ready for a review

[christiemolloy]

@guillaumevincent This implementation is great! The CSS aligns with what we have in pf-next. Only thing, I see there is an "Uncontrolled Switch" in react but not in pf-next, was this intentional? I assume that these should be synonymous, but correct me if I'm wrong :)

[guillaumevincent]

@christiemolloy I copy the Checkbox component here
Tell me if you want me to copy the pf-next implementation

@jschuler I agree for the event props should be first
Can we create an issue for this one? and fix it in another PR?

[guillaumevincent]

@jschuler just for your information you can propose change directly in the PR
See https://twitter.com/github/status/1054794897448939520

[guillaumevincent]

@jgiardino I added a PR on pf-core
I will update this PR on monday
Thanks

[mcarrano]

That's fair @guillaumevincent . I will consult with Visuals and open a new issue if we decide that the Switch labeling should be updated in both places.

I was going to mark this as "UX Approved" but looks like I don't have edit rights on this repo. @LHinson is that something you can enable?

[guillaumevincent]

@mcarrano I fix the label in pf-next
I propose to wait for patternfly/patternfly#877 to be merged
wdyt?

[mcarrano]

Yes, makes sense @guillaumevincent .

[rachael-phillips]

@dlabaj @mcarrano @tlabaj patternfly/patternfly#877 merged. Is this one ready for merge?

[mcarrano]

@rachael-phillips we had some discussion about the Switch component in the Accessibility meeting today and may be making some changes on the Core side. Opened a new issue here: patternfly/patternfly#914 We could merge this and create a new React issue or hold on this until core changes are made.

[dgutride]

We should let this in - @guillaumevincent - please make sure the build is passing and then it can be merged.

[rachael-phillips]

Thanks so much, Matt and Dana!

…

On Thu, Nov 8, 2018 at 1:59 PM mcarrano ***@***.***> wrote: @rachael-phillips <https://github.com/rachael-phillips> we had some discussion about the Switch component in the Accessibility meeting today and may be making some changes on the Core side. Opened a new issue here: patternfly/patternfly#914 <patternfly/patternfly#914> We could merge this and create a new React issue or hold on this until core changes are made. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#761 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AmaPXkbcaOUoPVeAMkilEtgFBY8CE7vDks5utH75gaJpZM4XcTyQ> .

[tlabaj]

LGTM

[christiemolloy]

@jgiardino do you know the status of the switch component. Was @mceledonia going to make visual updates? In this react example the text is "on/off" should we keep this wording or switch to "label" like we have in core.

[jgiardino]

If this is ready to merge then I'd vote to handle the visual updates (patternfly/patternfly#914) in a later PR since they haven't been implemented in core yet.

Let's keep On/Off here. There's also an issue in core to handle toggling the label (patternfly/patternfly#915). I suggested we change the label to "On" and "Off" in that issue. So let's keep "On"/"Off" in this one, and core will match when that issue is done.

[jschuler]

@jgiardino Sounds good, looks like this is good to merge and there are some followup items in the 2 issues you referenced.