Skip to content

Conversation

@tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Oct 25, 2018

…enerate a random id for the chi

What:

Added a Wrapper component that will generate a random ID for the child component

Additional issues:

@tlabaj tlabaj added the PF4 label Oct 25, 2018
@patternfly-build
Copy link
Collaborator

PatternFly-React preview: https://832-pr-patternfly-react-patternfly.surge.sh

@coveralls
Copy link

coveralls commented Oct 25, 2018

Pull Request Test Coverage Report for Build 2855

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 81.274%

Files with Coverage Reduction New Missed Lines %
packages/patternfly-4/react-core/src/components/Dropdown/Toggle.js 2 64.29%
Totals Coverage Status
Change from base Build 2821: 0.1%
Covered Lines: 3468
Relevant Lines: 4023

💛 - Coveralls

Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

dlabaj
dlabaj previously approved these changes Oct 26, 2018
dlabaj
dlabaj previously approved these changes Oct 26, 2018
@jschuler
Copy link
Collaborator

Looks like we have 2 competing approaches #830

amarie401
amarie401 previously approved these changes Oct 26, 2018
@tlabaj tlabaj dismissed stale reviews from amarie401 and dlabaj via 20d8938 October 26, 2018 13:29
jschuler
jschuler previously approved these changes Oct 26, 2018
dlabaj
dlabaj previously approved these changes Oct 26, 2018
@tlabaj tlabaj dismissed stale reviews from dlabaj and jschuler via 54ea495 October 26, 2018 13:35
@jschuler jschuler merged commit 159798e into patternfly:master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants