Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts - remove theme variant for v5 #8590

Merged
merged 1 commit into from
Feb 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions packages/react-charts/src/components/Chart/Chart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -445,14 +445,6 @@ export interface ChartProps extends VictoryChartProps {
* @example themeColor={ChartThemeColor.blue}
*/
themeColor?: string;
/**
* Specifies the theme variant. Valid values are 'dark' or 'light'
*
* Note: Not compatible with theme prop
*
* @deprecated Use PatternFly's pf-theme-dark CSS selector
*/
themeVariant?: string;
/**
* Specifies the width of the svg viewBox of the chart container. This value should be given as a
* number of pixels.
Expand Down Expand Up @@ -480,8 +472,6 @@ export const Chart: React.FunctionComponent<ChartProps> = ({
patternScale,
showAxis = true,
themeColor,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
themeVariant,

// destructure last
theme = getChartTheme(themeColor, showAxis),
Expand Down
10 changes: 0 additions & 10 deletions packages/react-charts/src/components/ChartArea/ChartArea.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -386,14 +386,6 @@ export interface ChartAreaProps extends VictoryAreaProps {
* @example themeColor={ChartThemeColor.blue}
*/
themeColor?: string;
/**
* Specifies the theme variant. Valid values are 'dark' or 'light'
*
* Note: Not compatible with theme prop
*
* @deprecated Use PatternFly's pf-theme-dark CSS selector
*/
themeVariant?: string;
/**
* The width props specifies the width of the svg viewBox of the chart container
* This value should be given as a number of pixels
Expand Down Expand Up @@ -439,8 +431,6 @@ export interface ChartAreaProps extends VictoryAreaProps {
export const ChartArea: React.FunctionComponent<ChartAreaProps> = ({
containerComponent = <ChartContainer />,
themeColor,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
themeVariant,

// destructure last
theme = getTheme(themeColor),
Expand Down
10 changes: 0 additions & 10 deletions packages/react-charts/src/components/ChartAxis/ChartAxis.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -385,14 +385,6 @@ export interface ChartAxisProps extends VictoryAxisProps {
* @example themeColor={ChartThemeColor.blue}
*/
themeColor?: string;
/**
* Specifies the theme variant. Valid values are 'dark' or 'light'
*
* Note: Not compatible with theme prop
*
* @deprecated Use PatternFly's pf-theme-dark CSS selector
*/
themeVariant?: string;
/**
* The tickComponent prop takes in an entire component which will be used
* to create tick lines. The new element created from the passed tickComponent
Expand Down Expand Up @@ -452,8 +444,6 @@ export const ChartAxis: React.FunctionComponent<ChartAxisProps> = ({
name,
showGrid = false,
themeColor,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
themeVariant,
tickLabelComponent = <ChartLabel />,
// destructure last
theme = getTheme(themeColor),
Expand Down
10 changes: 0 additions & 10 deletions packages/react-charts/src/components/ChartBar/ChartBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -420,14 +420,6 @@ export interface ChartBarProps extends VictoryBarProps {
* @example themeColor={ChartThemeColor.blue}
*/
themeColor?: string;
/**
* Specifies the theme variant. Valid values are 'dark' or 'light'
*
* Note: Not compatible with theme prop
*
* @deprecated Use PatternFly's pf-theme-dark CSS selector
*/
themeVariant?: string;
/**
* The width props specifies the width of the svg viewBox of the chart container
* This value should be given as a number of pixels
Expand Down Expand Up @@ -473,8 +465,6 @@ export interface ChartBarProps extends VictoryBarProps {
export const ChartBar: React.FunctionComponent<ChartBarProps> = ({
containerComponent = <ChartContainer />,
themeColor,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
themeVariant,

// destructure last
theme = getTheme(themeColor),
Expand Down
10 changes: 0 additions & 10 deletions packages/react-charts/src/components/ChartBullet/ChartBullet.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -447,14 +447,6 @@ export interface ChartBulletProps {
* @example themeColor={ChartThemeColor.blue}
*/
themeColor?: string;
/**
* Specifies the theme variant. Valid values are 'dark' or 'light'
*
* Note: Not compatible with theme prop
*
* @deprecated Use PatternFly's pf-theme-dark CSS selector
*/
themeVariant?: string;
/**
* The title for the chart
*/
Expand Down Expand Up @@ -526,8 +518,6 @@ export const ChartBullet: React.FunctionComponent<ChartBulletProps> = ({
standalone = true,
subTitle,
themeColor,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
themeVariant,
title,
titleComponent = <ChartBulletTitle />,
titlePosition,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,6 @@ export interface ChartBulletComparativeErrorMeasureProps {
* @example themeColor={ChartThemeColor.blue}
*/
themeColor?: string;
/**
* Specifies the theme variant. Valid values are 'dark' or 'light'
*
* Note: Not compatible with theme prop
*
* @deprecated Use PatternFly's pf-theme-dark CSS selector
*/
themeVariant?: string;
/**
* The width props specifies the width of the svg viewBox of the chart container
* This value should be given as a number of pixels
Expand Down Expand Up @@ -186,8 +178,6 @@ export const ChartBulletComparativeErrorMeasure: React.FunctionComponent<ChartBu
padding,
standalone = true,
themeColor,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
themeVariant,
y,

// destructure last
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,14 +145,6 @@ export interface ChartBulletComparativeMeasureProps {
* @example themeColor={ChartThemeColor.blue}
*/
themeColor?: string;
/**
* Specifies the theme variant. Valid values are 'dark' or 'light'
*
* Note: Not compatible with theme prop
*
* @deprecated Use PatternFly's pf-theme-dark CSS selector
*/
themeVariant?: string;
/**
* The width props specifies the width of the svg viewBox of the chart container
* This value should be given as a number of pixels
Expand Down Expand Up @@ -187,8 +179,6 @@ export const ChartBulletComparativeMeasure: React.FunctionComponent<ChartBulletC
padding,
standalone = true,
themeColor,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
themeVariant,
y,

// destructure last
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,6 @@ export interface ChartBulletComparativeWarningMeasureProps {
* @example themeColor={ChartThemeColor.blue}
*/
themeColor?: string;
/**
* Specifies the theme variant. Valid values are 'dark' or 'light'
*
* Note: Not compatible with theme prop
*
* @deprecated Use PatternFly's pf-theme-dark CSS selector
*/
themeVariant?: string;
/**
* The width props specifies the width of the svg viewBox of the chart container
* This value should be given as a number of pixels
Expand Down Expand Up @@ -186,8 +178,6 @@ export const ChartBulletComparativeWarningMeasure: React.FunctionComponent<Chart
padding,
standalone = true,
themeColor,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
themeVariant,
y,

// destructure last
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,6 @@ export interface ChartBulletGroupTitleProps {
* @example themeColor={ChartThemeColor.blue}
*/
themeColor?: string;
/**
* Specifies the theme variant. Valid values are 'dark' or 'light'
*
* Note: Not compatible with theme prop
*
* @deprecated Use PatternFly's pf-theme-dark CSS selector
*/
themeVariant?: string;
/**
* The title to render for grouped bullets
*/
Expand All @@ -126,8 +118,6 @@ export const ChartBulletGroupTitle: React.FunctionComponent<ChartBulletGroupTitl
standalone = true,
subTitle,
themeColor,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
themeVariant,
title,
titleComponent = <ChartLabel />,

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,6 @@ export interface ChartBulletPrimaryDotMeasureProps {
* @example themeColor={ChartThemeColor.blue}
*/
themeColor?: string;
/**
* Specifies the theme variant. Valid values are 'dark' or 'light'
*
* Note: Not compatible with theme prop
*
* @deprecated Use PatternFly's pf-theme-dark CSS selector
*/
themeVariant?: string;
/**
* The width props specifies the width of the svg viewBox of the chart container
* This value should be given as a number of pixels
Expand Down Expand Up @@ -195,8 +187,6 @@ export const ChartBulletPrimaryDotMeasure: React.FunctionComponent<ChartBulletPr
size = ChartBulletStyles.primaryDotMeasureSize,
standalone = true,
themeColor,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
themeVariant,
y,
y0,

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -159,14 +159,6 @@ export interface ChartBulletPrimarySegmentedMeasureProps {
* @example themeColor={ChartThemeColor.blue}
*/
themeColor?: string;
/**
* Specifies the theme variant. Valid values are 'dark' or 'light'
*
* Note: Not compatible with theme prop
*
* @deprecated Use PatternFly's pf-theme-dark CSS selector
*/
themeVariant?: string;
/**
* The width props specifies the width of the svg viewBox of the chart container
* This value should be given as a number of pixels
Expand Down Expand Up @@ -211,8 +203,6 @@ export const ChartBulletPrimarySegmentedMeasure: React.FunctionComponent<ChartBu
padding,
standalone = true,
themeColor,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
themeVariant,
y,
y0,

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,14 +149,6 @@ export interface ChartBulletQualitativeRangeProps {
* @example themeColor={ChartThemeColor.blue}
*/
themeColor?: string;
/**
* Specifies the theme variant. Valid values are 'dark' or 'light'
*
* Note: Not compatible with theme prop
*
* @deprecated Use PatternFly's pf-theme-dark CSS selector
*/
themeVariant?: string;
/**
* The width props specifies the width of the svg viewBox of the chart container
* This value should be given as a number of pixels
Expand Down Expand Up @@ -201,8 +193,6 @@ export const ChartBulletQualitativeRange: React.FunctionComponent<ChartBulletQua
padding,
standalone = true,
themeColor,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
themeVariant,
y,
y0,

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,6 @@ export interface ChartBulletTitleProps {
* @example themeColor={ChartThemeColor.blue}
*/
themeColor?: string;
/**
* Specifies the theme variant. Valid values are 'dark' or 'light'
*
* Note: Not compatible with theme prop
*
* @deprecated Use PatternFly's pf-theme-dark CSS selector
*/
themeVariant?: string;
/**
* The title to render for grouped bullets
*/
Expand Down Expand Up @@ -135,8 +127,6 @@ export const ChartBulletTitle: React.FunctionComponent<ChartBulletTitleProps> =
standalone = true,
subTitle,
themeColor,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
themeVariant,
title,
titleComponent = <ChartLabel />,
titlePosition,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ interface ChartBulletDataInterface {
negativeMeasureTheme?: ChartThemeDefinition;
theme?: ChartThemeDefinition;
themeColor?: string;
themeVariant?: string;
y?: DataGetterPropType;
y0?: DataGetterPropType;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ interface ChartBulletSizeInterface {
horizontal?: boolean; // Flag indicating chart is shown horizontally
theme?: ChartThemeDefinition;
themeColor?: string;
themeVariant?: string;
width: number; // The chart width -- not SVG width
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,14 +125,6 @@ export interface ChartContainerProps extends VictoryContainerProps {
* @example themeColor={ChartThemeColor.blue}
*/
themeColor?: string;
/**
* Specifies the theme variant. Valid values are 'dark' or 'light'
*
* Note: Not compatible with theme prop
*
* @deprecated Use PatternFly's pf-theme-dark CSS selector
*/
themeVariant?: string;
/**
* The title prop specifies the title to be applied to the SVG to assist
* accessibility for screen readers. The more descriptive this title is, the more
Expand All @@ -152,8 +144,6 @@ export interface ChartContainerProps extends VictoryContainerProps {
export const ChartContainer: React.FunctionComponent<ChartContainerProps> = ({
className,
themeColor,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
themeVariant,

// destructure last
theme = getTheme(themeColor),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,14 +191,6 @@ export interface ChartCursorContainerProps extends VictoryCursorContainerProps {
* @example themeColor={ChartThemeColor.blue}
*/
themeColor?: string;
/**
* Specifies the theme variant. Valid values are 'dark' or 'light'
*
* Note: Not compatible with theme prop
*
* @deprecated Use PatternFly's pf-theme-dark CSS selector
*/
themeVariant?: string;
/**
* The width props specifies the width of the svg viewBox of the container
* This value should be given as a number of pixels. If no width prop
Expand All @@ -211,8 +203,6 @@ export const ChartCursorContainer: React.FunctionComponent<ChartCursorContainerP
className,
cursorComponent = <LineSegment />,
themeColor,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
themeVariant,

// destructure last
theme = getTheme(themeColor),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -241,14 +241,6 @@ export interface ChartCursorTooltipProps extends ChartTooltipProps {
* @example themeColor={ChartThemeColor.blue}
*/
themeColor?: string;
/**
* Specifies the theme variant. Valid values are 'dark' or 'light'
*
* Note: Not compatible with theme prop
*
* @deprecated Use PatternFly's pf-theme-dark CSS selector
*/
themeVariant?: string;
/**
* This prop refers to the width of the svg that ChartCursorTooltip is rendered within. This prop is passed from
* parents of ChartCursorTooltip, and should not be set manually. In versions before ^33.0.0 this prop referred to the
Expand Down Expand Up @@ -277,8 +269,6 @@ export const ChartCursorTooltip: React.FunctionComponent<ChartCursorTooltipProps
showPointer = true,
style,
themeColor,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
themeVariant,

// destructure last
theme = getTheme(themeColor),
Expand Down
Loading