Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(innerRefs): hid innerRef props from various component docs #8648

Merged
merged 3 commits into from
Feb 8, 2023
Merged

fix(innerRefs): hid innerRef props from various component docs #8648

merged 3 commits into from
Feb 8, 2023

Conversation

nicolethoen
Copy link
Contributor

@nicolethoen nicolethoen commented Feb 3, 2023 •
edited
Loading

What: Closes #8233

@nicolethoen nicolethoen linked an issue Feb 3, 2023 that may be closed by this pull request
Breaking change: In some components innerRef prop is not hidden #8233
Closed
@patternfly-build
Copy link
Contributor

patternfly-build commented Feb 3, 2023 •
edited
Loading

Preview: https://patternfly-react-pr-8648.surge.sh

A11y report: https://patternfly-react-pr-8648-a11y.surge.sh

thatblindgeye
thatblindgeye reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there's just an innerRef in MenuGroup that isn't hidden.

tlabaj
tlabaj approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tlabaj tlabaj merged commit 18b1ef4 into patternfly:v5 Feb 8, 2023
@nicolethoen nicolethoen mentioned this pull request Feb 8, 2023
Closed
@nicolethoen nicolethoen mentioned this pull request Feb 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlabaj tlabaj tlabaj approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking change: In some components innerRef prop is not hidden
5 participants
@nicolethoen @patternfly-build @tlabaj @kmcfaul @thatblindgeye