fix(Popper): fixed flicker when opening popper content #9339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-9339.surge.sh A11y report: https://patternfly-react-pr-9339-a11y.surge.sh |
There was a problem hiding this comment.
One thing I'm noticing is that for Popover, there's now a noticeable delay when the Popover closes and the trigger receives focus again:
Popover.trigger.focus.delay.mov
Compared to the current behavior where the trigger receives focus fairly instantaneously. That's the only thing I think that's potentially blocking, just because we're swapping one visual bug with another (this might depend whether it makes sense for there to be this delay in the first place)
thatblindgeye
approved these changes
Jul 11, 2023
1 task
nicolethoen
pushed a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
* fix(Popper): fixed flicker when opening popper content * fixed re-focus delay when closing popover * updated DatePicker test to have consistent value
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9119
Additional issues:
Essentially this fixes the flicker by having the opacity change that makes the Popper content visible to users happen after Popper has initially rendered and figured out where it should be placed.
In accomplishing that goal I moved the largely identical opacity change logic in Tooltip/Popover directly into Popper.