Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(RTL): move RTL helper to utils file, refactor components to use it #9766

Merged
merged 2 commits into from
Oct 27, 2023
Merged

chore(RTL): move RTL helper to utils file, refactor components to use it #9766

merged 2 commits into from
Oct 27, 2023

Conversation

wise-king-sullyman
Copy link
Contributor

What: Closes #9657

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented Oct 23, 2023 •
edited
Loading

Preview: https://patternfly-react-pr-9766.surge.sh

A11y report: https://patternfly-react-pr-9766-a11y.surge.sh

@wise-king-sullyman wise-king-sullyman requested review from a team, nicolethoen and mfrances17 and removed request for a team October 25, 2023 20:17
tlabaj
tlabaj approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tlabaj tlabaj merged commit 90af1a7 into patternfly:main Oct 27, 2023
10 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@5.2.0-prerelease.17
  • @patternfly/react-core@5.2.0-prerelease.17
  • @patternfly/react-docs@6.2.0-prerelease.17
  • demo-app-ts@5.1.1-prerelease.40
  • @patternfly/react-table@5.2.0-prerelease.17

Thanks for your contribution! 🎉

@wise-king-sullyman wise-king-sullyman deleted the move-rtl-helper branch October 30, 2023 13:18
@renovate renovate bot mentioned this pull request Jul 27, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@tlabaj tlabaj tlabaj approved these changes

@nicolethoen nicolethoen Awaiting requested review from nicolethoen nicolethoen was automatically assigned from patternfly/react-reviewers

@mfrances17 mfrances17 Awaiting requested review from mfrances17 mfrances17 was automatically assigned from patternfly/react-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document and move RTL helper
4 participants
@wise-king-sullyman @patternfly-build @tlabaj @thatblindgeye