Skip to content

adding rule for hasNoBodyPadding in Wizard #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redallen merged 2 commits into from
May 21, 2020
Merged

adding rule for hasNoBodyPadding in Wizard #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9e10c2
adding rule for hasNoBodyPadding in Wizard
jenny-s51 May 20, 2020
7c5c4d8
rename to match issue
jenny-s51 May 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/eslint-plugin-pf-codemods/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const rules = {
"title-require-heading-level": require('./lib/rules/title-require-heading-level'),
"title-size": require('./lib/rules/title-size'),
"wizard-text": require('./lib/rules/wizard-text'),
"wizard-rename-hasBodyPadding": require('./lib/rules/wizard-rename-hasBodyPadding'),
};

module.exports = {
Expand Down
10 changes: 10 additions & 0 deletions packages/eslint-plugin-pf-codemods/lib/rules/wizard-rename-hasBodyPadding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
const { renameProp } = require('../helpers');

// https://github.com/patternfly/patternfly-react/pull/4136
module.exports = {
create: renameProp(
['Wizard', 'WizardBody', 'WizardToggle'],
{'hasBodyPadding': 'hasNoBodyPadding'},
node => `hasBodyPadding prop has been removed for ${node.name.name}. Use hasNoBodyPadding instead`
)
};
24 changes: 24 additions & 0 deletions packages/eslint-plugin-pf-codemods/test/rules/wizard-rename-hasBodyPadding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
const ruleTester = require('./ruletester');
const rule = require('../../lib/rules/wizard-rename-hasBodyPadding');

ruleTester.run("wizard-rename-hasBodyPadding", rule, {
valid: [
{
code: `import { Wizard } from '@patternfly/react-core'; <Wizard hasNoBodyPadding />`,
},
{
// No @patternfly/react-core import
code: `<Wizard hasNoBodyPadding />`,
Copy link
Contributor

@redallen redallen May 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also just be <Wizard hasNoPadding>. Since there's no import { Wizard } from '@patternfly/react-core'; it might be another Wizard implementation!

}
],
invalid: [
{
code: `import { Wizard } from '@patternfly/react-core'; <Wizard hasBodyPadding />`,
output: `import { Wizard } from '@patternfly/react-core'; <Wizard hasNoBodyPadding />`,
errors: [{
message: "hasBodyPadding prop has been removed for Wizard. Use hasNoBodyPadding instead",
type: "JSXOpeningElement",
}]
}
]
});