Conversation
redallen
reviewed
May 26, 2020
| } | ||
|
|
||
| return tabImport.length ? { | ||
| JSXOpeningElement(node) { |
Contributor
There was a problem hiding this comment.
Can we not target ImportDeclarations here? I'm going to check this out locally, but I think that'd be pretty nice...
redallen
approved these changes
May 26, 2020
Contributor
redallen
left a comment
redallen
left a comment
There was a problem hiding this comment.
I now see why we can't target ImportDeclarations... because we don't know if the rule will run!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23
Adds
<TabTitleText>wrapper for tab titles