Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bring node labels to top layer on hover #129

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

karthikjeeyar
Copy link
Collaborator

Fixes

#127

Description

Bring the node/group label to front when the node/group is hovered.

Type of change

  • Bugfix

Screen shots / Gifs for design review

Before:
onNodeHover_before

After:

node_group_label_hover

Copy link
Member

@jeff-phillips-18 jeff-phillips-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM

@jeff-phillips-18 jeff-phillips-18 merged commit d374319 into patternfly:main Jan 25, 2024
7 checks passed
Copy link

🎉 This PR is included in version 5.2.0-prerelease.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants