Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipelines): Add ability and styling for selected task edges #189

Merged

Conversation

jeff-phillips-18
Copy link
Member

What

Closes #187

Description

Adds WithSelection props to TaskEdge and styles for selection.

Type of change

  • Feature

Screen shots / Gifs for design review

image

image

@patternfly-build
Copy link

Copy link
Collaborator

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in demo app and task edge selection works as expected, LGTM. Great value add to the pipeline groups functionality.

@jeff-phillips-18 jeff-phillips-18 merged commit 814ec40 into patternfly:main May 10, 2024
13 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the pipeline-edge-selection branch May 10, 2024 11:45
Copy link

🎉 This PR is included in version 5.4.0-prerelease.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipelines should allow for selection of edges.
4 participants