Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dagre): Update dagre version to latest release #219

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

jeff-phillips-18
Copy link
Member

What

Closes #218

Description

Update dagre dependency to @dagrejs/dagre. This removes the dependency on lodash.

Type of change

  • Feature
  • Refactoring (no functional changes, no api changes)

Screen shots / Gifs for design review

Demo app surge: https://dagre-update.surge.sh/

@jeff-phillips-18 jeff-phillips-18 force-pushed the dagre-update branch 4 times, most recently from 8c976ea to cba7b24 Compare June 10, 2024 17:49
@jeff-phillips-18
Copy link
Member Author

dagrejs/dagre 1.1.2 requires node 18. I've updated the git workflows but they will not take effect on this PR only future PRs so the pr-preview check will not pass for this PR.

Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 yay for removing lodash!

@jeff-phillips-18 jeff-phillips-18 merged commit 6718a46 into patternfly:main Jun 11, 2024
7 of 8 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the dagre-update branch June 11, 2024 17:33
Copy link

🎉 This PR is included in version 5.4.0-prerelease.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update dagre dependency to remove lodash
4 participants