fix(edges): Fix colors for selected/hovered edges for light and dark themes #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenny-s51
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Looks great @jeff-phillips-18 awesome work on this fix. Tested in demo app and docs workspace - selected/hovered edges are applying the expected colors now. Curious if @andrew-ronaldson has any opinions on these colors, otherwise LGTM!
andrew-ronaldson
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #256
Description
Updates the colors for the line and background for the line for edges when selected and/or hovered.
Also updates the badges for labels to set style rather than fill and stroke properties so they don't get overridden by styling.
Type of change
Screen shots / Gifs for design review
Surge
https://connector-styles.surge.sh/