Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(v5-updates): Standardize on React 18, node 18, eslint, and PF v5 #43

Merged
merged 6 commits into from
May 2, 2023
Merged

chore(v5-updates): Standardize on React 18, node 18, eslint, and PF v5 #43

merged 6 commits into from
May 2, 2023

Conversation

dlabaj
Copy link
Contributor

@dlabaj dlabaj commented May 1, 2023

Fixes issue #28 and upgrades to PatternFly version 5.0

@dlabaj dlabaj self-assigned this May 1, 2023
wise-king-sullyman
wise-king-sullyman requested changes May 1, 2023
View reviewed changes
Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, also I think you need to update the release.config.js file as well, otherwise it will try to release alpha builds as prerelease versions.

packages/module/package.json Show resolved Hide resolved
packages/module/package.json Outdated Show resolved Hide resolved
packages/module/src/Feedback/FeedbackError.tsx Outdated Show resolved Hide resolved
packages/module/src/Feedback/FeedbackSuccess.tsx Outdated Show resolved Hide resolved
@jessiehuff jessiehuff linked an issue May 2, 2023 that may be closed by this pull request
Update User Feedback to match ext standards #28
Closed
@dlabaj dlabaj merged commit 3079721 into patternfly:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@nicolethoen nicolethoen Awaiting requested review from nicolethoen

@jessiehuff jessiehuff Awaiting requested review from jessiehuff

@tlabaj tlabaj Awaiting requested review from tlabaj

Assignees

@dlabaj dlabaj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update User Feedback to match ext standards
2 participants
@dlabaj @wise-king-sullyman