fix(docs): Updated development documentation. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlabaj
added
bug
dlabaj
requested review from
wise-king-sullyman,
nicolethoen,
jessiehuff and
edonehoo
edonehoo
reviewed
May 23, 2023
chore(docs): updated examples with explainations. chore(docs): updated examples with explainations. chore(docs): Added async example. chore(docs): reverted yarn.lock file. chore(docs): Updated with fake forms. chore(docs): Updated with fake forms. chore(docs): Updated with review comments. Review updates. Fixed bad link.
|
also - I don't see the "passes in email" example actually autofilling the test email. Is it meant to be displayed in the example form, or is it just happening in the background? 
(I was expecting this to have the test email already entered, but maybe I misunderstood)
|
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
dlabaj
added a commit
to dlabaj/react-user-feedback
that referenced
this pull request
May 30, 2023
chore(docs): updated examples with explainations. chore(docs): updated examples with explainations. chore(docs): Added async example. chore(docs): reverted yarn.lock file. chore(docs): Updated with fake forms. chore(docs): Updated with fake forms. chore(docs): Updated with review comments. Review updates. Fixed bad link.
dlabaj
added a commit
to dlabaj/react-user-feedback
that referenced
this pull request
May 31, 2023
chore(docs): updated examples with explainations. chore(docs): updated examples with explainations. chore(docs): Added async example. chore(docs): reverted yarn.lock file. chore(docs): Updated with fake forms. chore(docs): Updated with fake forms. chore(docs): Updated with review comments. Review updates. Fixed bad link.
dlabaj
added a commit
that referenced
this pull request
May 31, 2023
* fix(docs): Updated development documentation. (#55) chore(docs): updated examples with explainations. chore(docs): updated examples with explainations. chore(docs): Added async example. chore(docs): reverted yarn.lock file. chore(docs): Updated with fake forms. chore(docs): Updated with fake forms. chore(docs): Updated with review comments. Review updates. Fixed bad link. * fix(modal): Updated feedback modal to not use size as it's not needed for the PF v5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated development documentation.
https://react-user-feedback.surge.sh
Closes issue #50