Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add require entrypoint to follow bundler convention #48

Merged

Conversation

technicalpickles
Copy link
Contributor

By default, bundler will try to require the name of the rubygem. For
example, this gem is langchainrb, so it would try to
require "langchainrb".

That file doesn't exist, so when using bundler you'd need to explicitly
set require, ie:

gem "langchainrb", require: "langchain"

This adds lib/langchainrb.rb that only requires "langchain" so that
extra require: "langchain" isn't
necessary.

By default, bundler will try to require the name of the rubygem. For
example, this gem is langchainrb, so it would try to
`require "langchainrb"`.

That file doesn't exist, so when using bundler you'd need to explicitly
set `require`, ie:

```ruby
gem "langchainrb", require: "langchain"
```

This adds `lib/langchainrb.rb` that only requires "langchain" so that
extra `require: "langchain"` isn't
necessary.
Copy link
Contributor

@rickychilcott rickychilcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@andreibondarev
Copy link
Collaborator

@technicalpickles Please run standardrb --fix and let's ship it! Thank you!

@technicalpickles
Copy link
Contributor Author

Fixed!

@andreibondarev
Copy link
Collaborator

@technicalpickles Thank you for the contribution!

@andreibondarev andreibondarev merged commit bccd9e0 into patterns-ai-core:main May 24, 2023
@technicalpickles technicalpickles deleted the langchainrb-entrypoint branch May 24, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants