Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved logging #796

Merged
merged 8 commits into from
Sep 27, 2024
Merged

Improved logging #796

merged 8 commits into from
Sep 27, 2024

Conversation

dferrazm
Copy link
Contributor

  • Allow configuring the logger destination
  • Use Langchain logger on OpenAI client requests
  • Use Langchain logger on Google LLMs http requests
  • Less verbose logger by replacing info msgs with debug

@dferrazm dferrazm changed the title Better logging Improved logging Sep 27, 2024
@dferrazm dferrazm mentioned this pull request Sep 27, 2024
Open
4 tasks
@andreibondarev
Copy link
Collaborator

@dferrazm Could you please add an entry to the CHANGELOG.md?

@andreibondarev andreibondarev self-requested a review September 27, 2024 19:28
@andreibondarev andreibondarev merged commit 874c7e4 into patterns-ai-core:main Sep 27, 2024
5 checks passed
@andreibondarev
Copy link
Collaborator

@dferrazm Great job! 👏🏻

@dferrazm dferrazm deleted the better-logging branch September 30, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreibondarev andreibondarev andreibondarev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dferrazm @andreibondarev