Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check projpred version for latent projection #1456

Merged
merged 3 commits into from
Feb 14, 2023

Conversation

fweber144
Copy link
Contributor

I realized that in #1451, I could have checked the projpred version that is required for the latent projection directly in the code. Sorry, I have implemented this now (and also added corresponding documentation at argument latent; #1451 did so only in the NEWS entry).

@paul-buerkner
Copy link
Owner

Good point. Brms has the require_package function for this purpose.

Since `require_package()` uses `<` instead of `<=`, use projpred version 2.4.0
as cutoff (on CRAN, there is no projpred version between 2.3.0 and 2.4.0).
@codecov-commenter
Copy link

Codecov Report

Merging #1456 (1698d27) into master (1d4cb43) will decrease coverage by 0.02%.
The diff coverage is 12.50%.

❗ Current head 1698d27 differs from pull request most recent head 75cedce. Consider uploading reports for the commit 75cedce to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1456      +/-   ##
==========================================
- Coverage   82.06%   82.05%   -0.02%     
==========================================
  Files          70       70              
  Lines       19720    19724       +4     
==========================================
+ Hits        16183    16184       +1     
- Misses       3537     3540       +3     
Impacted Files Coverage Δ
R/projpred.R 0.00% <0.00%> (ø)
R/data-response.R 89.43% <33.33%> (-0.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fweber144
Copy link
Contributor Author

Thanks, I switched to require_package() (commit 75cedce). Since require_package() uses < instead of <=, I consistently switched to projpred version 2.4.0 as cutoff instead of 2.3.0 (on CRAN, there is no projpred version between 2.3.0 and 2.4.0).

@paul-buerkner
Copy link
Owner

Perfect, thank you!

@paul-buerkner paul-buerkner merged commit b31fcee into paul-buerkner:master Feb 14, 2023
@fweber144 fweber144 deleted the projpred_version_latent branch February 14, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants