Skip to content

Commit

Permalink
[inspector] should ignore asyncTask* with null
Browse files Browse the repository at this point in the history
In V8Debugger code we don't expect task_id == null, e.g.
asyncTaskStartedForStepping will trigger debug break on null as task_id.
Let's filter task_id == null out.

This issue is originally filed in Node.js:
nodejs/node#15464

R=dgozman@chromium.org

Bug: none
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icc9f96105b3c91ee1b102d545a7817f7ee93394c
Reviewed-on: https://chromium-review.googlesource.com/695808
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48265}
  • Loading branch information
alexkozy authored and Commit Bot committed Oct 3, 2017
1 parent 631489b commit f4a2b7f
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/inspector/v8-inspector-impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -289,18 +289,22 @@ std::unique_ptr<V8StackTrace> V8InspectorImpl::captureStackTrace(

void V8InspectorImpl::asyncTaskScheduled(const StringView& taskName, void* task,
bool recurring) {
if (!task) return;
m_debugger->asyncTaskScheduled(taskName, task, recurring);
}

void V8InspectorImpl::asyncTaskCanceled(void* task) {
if (!task) return;
m_debugger->asyncTaskCanceled(task);
}

void V8InspectorImpl::asyncTaskStarted(void* task) {
if (!task) return;
m_debugger->asyncTaskStarted(task);
}

void V8InspectorImpl::asyncTaskFinished(void* task) {
if (!task) return;
m_debugger->asyncTaskFinished(task);
}

Expand Down

0 comments on commit f4a2b7f

Please sign in to comment.