Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaCMS with the new modules #22

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

yaCMS with the new modules #22

wants to merge 8 commits into from

Conversation

raul21
Copy link

@raul21 raul21 commented Jan 13, 2012

The modules is now up to date. I hope that all of them. The functionality is the same as in the commit 8e024f2.

@paulbarbu
Copy link
Owner

You implemented a NEW reload system in 63f3592.
Couldn't you use the existing one under the comment: Reload the page if the module or the dependencies says so ?

It works, I haven't tested it intensively, but it seems that you duplicated some code there.

Please update your fork because I fixed a bug in my reloading system.

@raul21
Copy link
Author

raul21 commented Jan 21, 2012

It isn't a new reload system in 63f3592. It is for the loading of a page. Only for some yaCMS modules.
Where I duplicated the code?
I updated my fork.

@raul21 raul21 closed this Jan 21, 2012
@raul21 raul21 reopened this Jan 21, 2012
@raul21
Copy link
Author

raul21 commented Jan 21, 2012

I accidentally closed the pull request. I reopen it. Sorry.

@paulbarbu
Copy link
Owner

It does the very same thing as the normal reload I implemented.
Please use the current reload system, you just changes some keys in the retval.

@raul21
Copy link
Author

raul21 commented Jan 26, 2012

I used the current reload system but this it creates some problems wich must be solved at one moment.
For example, $feedback_pre['autologin']['prev'] becomes useless.

@paulbarbu
Copy link
Owner

For example, $feedback_pre['autologin']['prev'] becomes useless.

It does not.
If the user tries to access a module (lets say module foo) that requires authentication and the user is not logged in he will be redirected to the log in module and if he authenticates himself then you must redirect him back to the module that he requested, more specifically, to module foo, this is where $feedback_pre['autologin']['prev'] kicks in.

The rest of the changes are OK.

Edit: Check this link for further clarification on the subject and see how that was done before the backwards compatibility breakage.

@raul21
Copy link
Author

raul21 commented Jan 26, 2012

Yes, this is what the $feedback['autologin']['prev']
must do. But, it does? Not yet. This it still remains a problem.
I said that $feedback_pre['autologin']['prev'] becomes useless
because after the repeatedly recharging of the login_* module
$feedback_pre['autologin']['prev'] becomes NULL imediately
before loading VL. This was not a problem in the commit
0e19af1..., that one with what seemed "a NEW reload system".
Work because the $module variable received a value timely.
But, there must be a better solution for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants