Esri#770 - add right to left support for dropdown-right

paulcpederson · Feb 28, 2017 · 3763899 · 3763899
1 parent 95c4f2c
commit 3763899
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@
 - added right-to-left styles for tabs (#776)
 - fixed elements inside accordions triggering close event (#774)
 - fix alignment of shorter loader-text (#771)
+- added right-to-left styles for dropdown-right modifier (#770)
 
 ## 1.0.0-rc.1
 

diff --git a/lib/sass/calcite-web/components/_dropdown.scss b/lib/sass/calcite-web/components/_dropdown.scss
@@ -53,15 +53,17 @@
         position: absolute;
         right: .35rem;
       }
-      html[dir="rtl"] &:after {
-        right: auto;
-        left: .35rem;
-        padding-left: 0;
-      }
+      @if ($include-right-to-left) {
+        html[dir="rtl"] &:after {
+          right: auto;
+          left: .35rem;
+          padding-left: 0;
+        }
 
-      html[dir="rtl"] & {
-        padding-left: 1.5rem;
-        padding-right: 0.9rem;
+        html[dir="rtl"] & {
+          padding-left: 1.5rem;
+          padding-right: 0.9rem;
+        }
       }
     // for inline svg, the code is much easier
     } else {
@@ -81,6 +83,12 @@
     overflow: auto;
     &.dropdown-right {
       right: 0;
+      @if ($include-right-to-left) {
+        html[dir="rtl"] & {
+          right: auto;
+          left: 0;
+        }
+      }
     }
   }