Esri#836 - remove unused grid fallbacks

paulcpederson · Apr 9, 2018 · 38a7f8d · 38a7f8d
1 parent 53f76fc
commit 38a7f8d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+## [Unreleased][unreleased]
+
+### Fixes
+- remove unused grid configuration variables (#836)
+
 ## [1.0.1][1.0.1]
 
 ### Fixes
@@ -1356,6 +1361,7 @@ Begin foundational sass for the framework.
 - CSS Reset
 - Grunt Workflows
 
+[unreleased]: https://github.com/esri/calcite-web/compare/v1.0.1...HEAD
 [1.0.1]: https://github.com/esri/calcite-web/compare/v1.0.0...v1.0.1
 [1.0.0]: https://github.com/esri/calcite-web/compare/v1.0.0-rc.9...v1.0.0
 [1.0.0-rc.8]: https://github.com/esri/calcite-web/compare/v1.0.0-rc.7...v1.0.0-rc.8

diff --git a/docs/source/documentation/grid/_configuration.md b/docs/source/documentation/grid/_configuration.md
@@ -8,9 +8,7 @@ If you are using Calcite Web as a Sass library, you can customize the grid with
 | `$large`                    | 1450px  | Default (desktop) breakpoint size in pixels       |
 | `$vw-ratio`                 | 0.95    | Amount of screen used by grid (0 - 1)             |
 | `$column-gutter`            | 1rem    | Space between columns                             |
-| `$ie8-support`              | false   | Whether you'd like to support Internet Explorer 8 |
 | `$container-width`          | 1450px  | Max size of `grid-container` element in pixels    |
-| `$column-gutter-fallback`   | 20px    | Fallback for space between columns for IE8        |
 | `$container-width-fallback` | 960px   | Fixed container size                              |
 | `$default-column-count`     | 24      | How many columns to use on the desktop breakpoint |
 | `$medium-class`             | tablet  | Prefix word for tablet breakpoint                 |

diff --git a/lib/sass/calcite-web/base/_config.scss b/lib/sass/calcite-web/base/_config.scss
@@ -38,8 +38,6 @@ $max-width:                $vw-ratio * 100vw           !default;
 $column-gutter:            1rem                        !default;
 
 // Grid Fallback Options
-$ie8-support:              false                       !default;
-$column-gutter-fallback:   20px                        !default;
 $container-width-fallback: 960px                       !default;
 
 // Medium