Test container implementation for Azure blob tests #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Paul, my curiosity got the better of me and I decided to look into the Azure docker container implementation.
It seemed obvious to me that it would be better to try it out with a real-world scenario, so I took the liberty of converting the Azure tests to use my test container implementation. There actually isn't much to this in the end but it now means the Azure tests could run without a pre-defined Azure set-up and would make development for spring-content noobs like myself easier moving forward.
I hope you don't mind that I have opened a PR but please feel free to reject it if this isn't a road you would want to go down.
Cheers, Andy.