Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

klocalizer: fix using --sample 0 with --report-all #96

Merged
merged 1 commit into from
Aug 28, 2021

Conversation

necipfazil
Copy link
Collaborator

--report-all fails with --sample 0 or without sample flag although it should not. Fix this.

Fixes #84

--report-all fails with --sample 0 although it should not. Fix this.
@necipfazil necipfazil requested a review from paulgazz August 28, 2021 11:36
Copy link
Owner

@paulgazz paulgazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulgazz paulgazz merged commit c6e83a0 into master Aug 28, 2021
@necipfazil necipfazil deleted the necip-fix-sampling branch September 14, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

klocalizer fails for --report-all
2 participants