Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ActiveSupport as a dependency #8

Merged
merged 1 commit into from
Jun 24, 2016

Conversation

paulgoetze
Copy link
Owner

Since only a fraction of ActiveSupport’s functionality is used (concerns, and a couple of String methods, like #blank, #demodulize, #(de)constantize) there is no need to rely on the full dependency.

Now uses plain

def self.included(base)
  base.extend(ClassMethods)
end

and

def self.included(base)
  base.class_eval do
    # ...
  end
end

instead of ActiveSupport::Concerns and implement the string methods itself.

@paulgoetze paulgoetze merged commit e67eb49 into develop Jun 24, 2016
@paulgoetze paulgoetze deleted the feature/drop-activesupport-dependency branch June 24, 2016 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant